Closed
Bug 1350597
Opened 7 years ago
Closed 7 years ago
WebExtensions: reloading a sidebar extension on about:debugging closes sidebar
Categories
(WebExtensions :: Frontend, defect)
Tracking
(firefox55 fixed)
RESOLVED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: geoffreydebelie, Assigned: mixedpuppy)
Details
(Whiteboard: triaged)
Attachments
(1 file)
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:55.0) Gecko/20100101 Firefox/55.0 Build ID: 20170314110401 Steps to reproduce: 1) Load a WebExtension that uses the sidebar API on about:debugging "sidebar_action": { "default_icon": "icons/icon.png", "default_title" : "Sidebar", "default_panel": "sidebar.html" } -> A sidebar opens 2) Press the button reload -> The sidebar closes and doesn't open again! Expected results: The sidebar should re-open after the extension is reloaded.
Updated•7 years ago
|
Component: WebExtensions: Untriaged → WebExtensions: Frontend
Assignee | ||
Comment 1•7 years ago
|
||
I was about to wont-fix this, however this also affects addon upgrade from AMO.
Assignee: nobody → mixedpuppy
Status: UNCONFIRMED → NEW
Ever confirmed: true
Whiteboard: triaged
Comment hidden (mozreview-request) |
Comment 3•7 years ago
|
||
mozreview-review |
Comment on attachment 8858398 [details] Bug 1350597 fix reload/upgrade of sidebar addon, https://reviewboard.mozilla.org/r/130346/#review133064 ::: browser/components/extensions/ext-sidebarAction.js:104 (Diff revision 1) > build() { > this.tabContext.on("tab-select", // eslint-disable-line mozilla/balanced-listeners > (evt, tab) => { this.updateWindow(tab.ownerGlobal); }); > > let install = this.extension.startupReason === "ADDON_INSTALL"; > + let upgrade = this.extension.startupReason === "ADDON_UPGRADE"; Should also accept ADDON_DOWNGRADE.
Attachment #8858398 -
Flags: review?(kmaglione+bmo) → review+
Comment hidden (mozreview-request) |
Pushed by mixedpuppy@gmail.com: https://hg.mozilla.org/integration/autoland/rev/45f5b5a65b7f fix reload/upgrade of sidebar addon, r=kmag
Comment 6•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/45f5b5a65b7f
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Updated•6 years ago
|
Product: Toolkit → WebExtensions
You need to log in
before you can comment on or make changes to this bug.
Description
•