1350662 - [e10s] Background color of options select is white

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect)

Description

[blinky]

Attachment: test case

Steps to reproduce:

1. Open attached.
2. Open the <select> element.


Actual results:

The background is white.

Comment 1

[blinky]

Regression range:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=bf6b9caab2c7eb3ebc642afd82bc19598829c6f3&tochange=6cefe01ca7744d6ac3960c69eac833e2e65f7f8f

Regressed by: bug 1338850

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1350662 - Don't compare the select background color with the foreground color since it may be changed by the options.

The comparison being removed was only put in place because it seemed like a "good-idea" to prevent <select> from being unreadable, though it's not a fool-proof strategy and it breaks content that uses different styling approaches. This removal does not regress any of the other test cases.

Review commit: https://reviewboard.mozilla.org/r/124382/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/124382/

Comment 3

[Dave Townsend [:mossop] (PTO until Aug 21st)]

Comment on attachment 8852157 [details]
Bug 1350662 - Don't compare the select background color with the foreground color since it may be changed by the options.

https://reviewboard.mozilla.org/r/124382/#review126970

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4a2367fccc8e
Don't compare the select background color with the foreground color since it may be changed by the options. r=mossop

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4a2367fccc8e

Comment 6

[Nathan Froyd [:froydnj]]

Please request Aurora approval on this when you get a chance.

Comment 7

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8852157 [details]
Bug 1350662 - Don't compare the select background color with the foreground color since it may be changed by the options.

Approval Request Comment
[Feature/Bug causing the regression]: regression from bug 910022
[User impact if declined]: <select> menus may look broken on some webpages
[Is this code covered by automated tests?]: yes
[Has the fix been verified in Nightly?]: not "verified" but it has been on nightly for some time now with no bugs filed against it and the bug reporter has done an amazing job hunting for bugs with the feature
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: this patch must be applied on top of the ones from bug 1349701 and bug 1348617, in that order
[Is the change risky?]: no
[Why is the change risky/not risky?]: limited to just select popups, this is following other patches that have been uplifted to for bug 910022
[String changes made/needed]: none

Comment 8

[Jared Wein [:jaws] (please needinfo? me)]

(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #7)
> [Has the fix been verified in Nightly?]: not "verified" but it has been on
> nightly for some time now with no bugs filed against it and the bug reporter
> has done an amazing job hunting for bugs with the feature

Sorry, scratch the above. This just landed on Nightly yesterday, though after letting it sit on Nightly for a few days we should be able to uplift it.

Comment 9

[Gerry Chang [:gchang]]

Comment on attachment 8852157 [details]
Bug 1350662 - Don't compare the select background color with the foreground color since it may be changed by the options.

Fix a regression related to <select> element and was verified in comment #13 of bug 1348617. Aurora54+.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/a6ba68e32810