Set the pref to enable dom.storageManager in tests that depend on it being enabled

RESOLVED FIXED in Firefox 55

Status

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: philor, Assigned: philor)

Tracking

Trunk
mozilla55
Points:
---

Firefox Tracking Flags

(firefox-esr45 unaffected, firefox52 unaffected, firefox-esr52 unaffected, firefox53 unaffected, firefox54 unaffected, firefox55 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
dom.storageManager.enabled is only set for Nightly, so the armload of storage/ tests that depend on it being set to work need to set it to avoid permaorange when trunk merges to aurora on 2017-04-17.
(Assignee)

Comment 1

2 years ago
Created attachment 8851412 [details] [diff] [review]
Enable it

https://treeherder.mozilla.org/#/jobs?repo=try&revision=108db6e931a19a7fd2f442ec2c593381250cb8a2 probably says I got rid of all the typos on my second attempt.
Assignee: nobody → philringnalda
Status: NEW → ASSIGNED
Attachment #8851412 - Flags: review?(james)
(Assignee)

Updated

2 years ago
status-firefox52: --- → unaffected
status-firefox53: --- → unaffected
status-firefox54: --- → unaffected
status-firefox55: --- → affected
status-firefox-esr45: --- → unaffected
status-firefox-esr52: --- → unaffected
Comment on attachment 8851412 [details] [diff] [review]
Enable it

Could also gave set this in a __dir__.ini file in testing/web-platform/meta/storage/
Attachment #8851412 - Flags: review?(james) → review+

Comment 3

2 years ago
Pushed by philringnalda@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/63ff56600b67
Set the pref to enable dom.storageManager in tests that depend on it being enabled, r=jgraham

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/63ff56600b67
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox55: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
(Assignee)

Comment 5

2 years ago
I'll probably live to regret not using a __dir__.ini for all three pref-setting patches, but baby steps, baby steps.
(Assignee)

Comment 6

2 years ago
Living to regret it right now, that didn't take very long.

Comment 7

2 years ago
Pushed by philringnalda@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7d9c92e2215c
set the pref to enable dom.storageManager in a __dir__.ini instead of playing Whac-A-Test
You need to log in before you can comment on or make changes to this bug.