1350798 - Ignore v4 completion too early will cause telemetry::URLCLASSIFIER_MATCH_RESULT gets wrong results

Status: RESOLVED FIXED

(Toolkit :: Safe Browsing, enhancement, P2)

Description

[Dimi Lee [:dimi]]

Right now we enable completion but ignore the lookup result by checking preference in nsUrlClassifierLookupCallback::Completion[1]. But this will cause us measure incorrect match result[2] because completions for v4 are ignored.

We should skip v4 completion result in nsUrlClassifierLookupCallback::HandleResults to get correct telemetry record.

[1] https://dxr.mozilla.org/mozilla-central/source/toolkit/components/url-classifier/nsUrlClassifierDBService.cpp#1139
[2] https://dxr.mozilla.org/mozilla-central/source/toolkit/components/url-classifier/nsUrlClassifierDBService.cpp#1269

Comment 1

[Dimi Lee [:dimi]]

Attachment: Bug 1350798 - Ignore v4 completion too early will cause telemetry::URLCLASSIFIER_MATCH_RESULT gets wrong results.

Enable safebrowsing v4 completion but ignore the result by checking preference in
nsUrlClassifierLookupCallback::Completion may cause telemetry measure incorrect match
result since v4 completions will always be ingored.

So in this patch we move the preference check after telemetry is measured and
then we ignore the result.

Review commit: https://reviewboard.mozilla.org/r/123814/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/123814/

Comment 2

[François Marier [:francois]]

Comment on attachment 8851493 [details]
Bug 1350798 - Ignore v4 completion too early will cause telemetry::URLCLASSIFIER_MATCH_RESULT gets wrong results.

https://reviewboard.mozilla.org/r/123814/#review126362

::: commit-message-cc537:5
(Diff revision 1)
> +Bug 1350798 - Ignore v4 completion too early will cause telemetry::URLCLASSIFIER_MATCH_RESULT gets wrong results. r?francois
> +
> +Enable safebrowsing v4 completion but ignore the result by checking preference in
> +nsUrlClassifierLookupCallback::Completion may cause telemetry measure incorrect match
> +result since v4 completions will always be ingored.

typo: ignored

Comment 3

[Dimi Lee [:dimi]]

Comment on attachment 8851493 [details]
Bug 1350798 - Ignore v4 completion too early will cause telemetry::URLCLASSIFIER_MATCH_RESULT gets wrong results.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/123814/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/770d755ed395
Ignore v4 completion too early will cause telemetry::URLCLASSIFIER_MATCH_RESULT gets wrong results. r=francois

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/770d755ed395