Replace use of int64_t for microseconds by TimeUnit in AudioSink

RESOLVED FIXED in Firefox 55

Status

()

Core
Audio/Video: Playback
P3
normal
RESOLVED FIXED
9 months ago
9 months ago

People

(Reporter: jwwang, Assigned: jwwang)

Tracking

(Blocks: 1 bug)

unspecified
mozilla55
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox55 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Updated

9 months ago
Assignee: nobody → jwwang
Blocks: 1245019
Priority: -- → P3
Comment hidden (mozreview-request)
(Assignee)

Updated

9 months ago
Attachment #8851855 - Flags: review?(kikuo)

Comment 2

9 months ago
mozreview-review
Comment on attachment 8851855 [details]
Bug 1350814 - Replace use of int64_t for microseconds by TimeUnit in AudioSink.

https://reviewboard.mozilla.org/r/124062/#review126576
Attachment #8851855 - Flags: review?(kikuo) → review+
(Assignee)

Comment 3

9 months ago
Thanks!

Comment 4

9 months ago
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 16d7050cd29e -d 4ac559eea9ec: rebasing 385492:16d7050cd29e "Bug 1350814 - Replace use of int64_t for microseconds by TimeUnit in AudioSink. r=kikuo" (tip)
merging dom/media/MediaDecoderStateMachine.cpp
merging dom/media/mediasink/AudioSink.cpp
merging dom/media/mediasink/AudioSinkWrapper.cpp
warning: conflicts while merging dom/media/mediasink/AudioSink.cpp! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 5

9 months ago
Pushed by jwwang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bf0f89726139
Replace use of int64_t for microseconds by TimeUnit in AudioSink. r=kikuo

Comment 6

9 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/bf0f89726139
Status: NEW → RESOLVED
Last Resolved: 9 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Unfortunate that all those TimeUnits are passed by value rather than const preferences...

JW, could you open a follow up bug about those?

thanks.
Flags: needinfo?(jwwang)
(Assignee)

Comment 8

9 months ago
Do you mean the constructor of AudioSink? Yes I will open a new bug to fix that. Thanks for the reminder.
Flags: needinfo?(jwwang)
(Assignee)

Updated

9 months ago
Blocks: 1351586
You need to log in before you can comment on or make changes to this bug.