|Submitter||Diff||Changes||Open Issues||Last Updated|
|Error loading review requests:|
59 bytes, text/x-review-board-request
|Details | Review|
Comment on attachment 8851855 [details] Bug 1350814 - Replace use of int64_t for microseconds by TimeUnit in AudioSink. https://reviewboard.mozilla.org/r/124062/#review126576
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again. hg error in cmd: hg rebase -s 16d7050cd29e -d 4ac559eea9ec: rebasing 385492:16d7050cd29e "Bug 1350814 - Replace use of int64_t for microseconds by TimeUnit in AudioSink. r=kikuo" (tip) merging dom/media/MediaDecoderStateMachine.cpp merging dom/media/mediasink/AudioSink.cpp merging dom/media/mediasink/AudioSinkWrapper.cpp warning: conflicts while merging dom/media/mediasink/AudioSink.cpp! (edit, then use 'hg resolve --mark') unresolved conflicts (see hg resolve, then hg rebase --continue)
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/bf0f89726139 Replace use of int64_t for microseconds by TimeUnit in AudioSink. r=kikuo
Unfortunate that all those TimeUnits are passed by value rather than const preferences... JW, could you open a follow up bug about those? thanks.
Do you mean the constructor of AudioSink? Yes I will open a new bug to fix that. Thanks for the reminder.