1350853 - stylo: Stylo serializes all angle specified values a radians

Status: RESOLVED WORKSFORME

(Core :: CSS Parsing and Computation, enhancement, P3)

Description

[Emilio Cobos Álvarez [:emilio]]

Chrome and Gecko preserve the unit. We should probably do the same.

Comment 1

[Emilio Cobos Álvarez [:emilio]]

I'm not sure if Gecko keeps it for computed values, but the following test-case seems to indicate that blink normalizes to degrees instead of radians at computed value time:

<!doctype html>
<div></div>
<script>
  var el = document.querySelector('div');
  el.style.offsetRotation = "10deg";
  alert(el.style.offsetRotation);
  alert(getComputedStyle(el).offsetRotation);
  el.style.offsetRotation = "10rad";
  alert(el.style.offsetRotation);
  alert(getComputedStyle(el).offsetRotation);
</script>

Comment 2

[Cameron McCormack (:heycam)]

It might be that https://drafts.csswg.org/css-values/#compat means we should serialize as degrees.

Comment 3

[Xidorn Quan [:xidorn] UTC+10]

What is offsetRotation actually? It seems to me that both Gecko and Blink returns undefined for getComputedStyle(el).offsetRotation.

Comment 4

[Xidorn Quan [:xidorn] UTC+10]

And if I change the code to do
> el.style.transform = "rotate(10deg)";
instead, it would correctly report "rotate(10deg)" for specified value. I suppose this means WFM.

Comment 5

[Emilio Cobos Álvarez [:emilio]]

(In reply to Xidorn Quan [:xidorn] UTC+10 from comment #3)
> What is offsetRotation actually? It seems to me that both Gecko and Blink
> returns undefined for getComputedStyle(el).offsetRotation.

Huh, you're right... I'm pretty sure it worked at some point? Shrug.

I think you fixed this anyway :)