Closed Bug 1350881 Opened 7 years ago Closed 7 years ago

Clean up button styling for Windows Classic

Categories

(Toolkit :: Themes, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: dao, Assigned: dao)

References

Details

Attachments

(1 file)

We should use the -moz-windows-classic media query instead of :-moz-system-metric (because the latter needlessly increases the rule's specificity) and get rid of the button[disabled="true"] > .button-box rule using !important to override the padding for the active/open/checked state.
Comment on attachment 8851577 [details]
Bug 1350881 - Clean up button styling for Windows Classic.

https://reviewboard.mozilla.org/r/123866/#review126748

Much better, thank you!
Attachment #8851577 - Flags: review?(jhofmann) → review+
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1df150b82bbd
Clean up button styling for Windows Classic. r=johannh
https://hg.mozilla.org/mozilla-central/rev/1df150b82bbd
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Blocks: 1341048
Blocks: 1351998
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: