Closed
Bug 1350894
Opened 8 years ago
Closed 8 years ago
Check if the node is dead in getOffsetParent
Categories
(DevTools :: Inspector, defect, P3)
DevTools
Inspector
Tracking
(firefox55 fixed)
RESOLVED
FIXED
Firefox 55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: gl, Assigned: gl)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
828 bytes,
patch
|
pbro
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•8 years ago
|
||
Attachment #8851584 -
Flags: review?(pbrosset)
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8851584 [details] [diff] [review]
1350894.patch
Review of attachment 8851584 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks for the fix!
Things like this are exactly why it's good to write tests with the implementation, because tests force you to think about edge cases.
Do we have tests for this new method already? Can we add some if not please?
Attachment #8851584 -
Flags: review?(pbrosset) → review+
|
|
Assignee | |
Updated•8 years ago
|
Pushed by gabriel.luong@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/dd664243e4b4
Check if the node is dead in getOffsetParent. r=pbro
|
||
Comment 4•8 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•