Open
Bug 1350916
Opened 8 years ago
Updated 3 years ago
use fuzzy annotation for subtle differences instead of making #mask hack in video/audio controls reftests
Categories
(Toolkit :: Video/Audio Controls, enhancement)
Tracking
()
NEW
Tracking | Status | |
---|---|---|
firefox55 | --- | affected |
People
(Reporter: ralin, Unassigned)
References
Details
Right now, we're using #mask hack to cover irrelevant area to hide subtle differences in reftests in order to pass. We should use fuzzy annotation instead.
Comment 1•8 years ago
|
||
(In reply to Ray Lin[:ralin] from comment #0)
> Right now, we're using #mask hack to cover irrelevant area to hide subtle differences
Per bug 1350927 comment 2, for the reftests-shoehorned-into-mochitest tests that use "videomask.css", it seems like in fact the #mask was originally there to cover *not-at-all* subtle differences -- it was covering a throbber whose rotation state was impossible to predict.
I think that throbber isn't part of our controls anymore, though, so we might just be able to just remove the mask and be done with it.
Summary: use fuzzy annotation for subtle differences instead of making #mask hack in reftest → use fuzzy annotation for subtle differences instead of making #mask hack in video/audio controls reftests
Updated•3 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•