1350935 - "mach mochitest --appname dist" gives a not very useful error message when the build hasn't been packaged yet

Status: NEW

(Testing :: Mochitest, defect)

Description

[Florian Quèze [:florian]]

"mach mochitest --appname dist" only works if "mach package" has been ran before. If somehow a clobber occured I need to remember to "mach package" again. If I forget, the unhelpful error message I get is the following:


$ ./mach mochitest --appname dist browser/base/content/test/static/browser_all_files_referenced.js
cat: backend.TestManifestBackend.in: No such file or directory
Build configuration changed. Regenerating backend.

######
### Now running mochitest-browser.
######

Error running mach:

    ['mochitest', '--appname', 'dist', 'browser/base/content/test/static/browser_all_files_referenced.js']

The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.

You should consider filing a bug for this issue.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

Exception: Binary expected at /Users/florian/buildhg/mozilla/obj-browser/dist/firefox/Nightly.app/Contents/MacOS/firefox does not exist.

  File "/Users/florian/buildhg/mozilla/testing/mochitest/mach_commands.py", line 408, in run_mochitest_general
    **harness_args)
  File "/Users/florian/buildhg/mozilla/testing/mochitest/mach_commands.py", line 158, in run_desktop_test
    result = mochitest.run_test_harness(parser, options)
  File "/Users/florian/buildhg/mozilla/obj-browser/_tests/testing/mochitest/runtests.py", line 2751, in run_test_harness
    parser.validate(options)
  File "/Users/florian/buildhg/mozilla/obj-browser/_tests/testing/mochitest/mochitest_options.py", line 1104, in validate
    args = container.validate(self, args, self.context)
  File "/Users/florian/buildhg/mozilla/obj-browser/_tests/testing/mochitest/mochitest_options.py", line 639, in validate
    options.app = build_obj.get_binary_path(where='staged-package')
  File "/Users/florian/buildhg/mozilla/python/mozbuild/mozbuild/base.py", line 336, in get_binary_path
    raise Exception('Binary expected at %s does not exist.' % path)


I think in that case mach should either say "please run mach package", or even better just do it automatically.