1350955 - Enable adaptive mutex on FreeBSD

Status: RESOLVED FIXED

(Core :: mozglue, enhancement)

Description

[Jan Beich]

PTHREAD_MUTEX_ADAPTIVE_NP is supported since FreeBSD 8.0. Getting patches accepted in NSPR is too hard: very few reviewers + a lot of cruft. I'll try but let's not block on that.

https://github.com/freebsd/freebsd/commit/bbfd76f8722c569a2be8de7fd01318fa54fa750c

Comment 1

[Jan Beich]

Attachment: Bug 1350955 - Enable adaptive mutex usage on FreeBSD.

Review commit: https://reviewboard.mozilla.org/r/123902/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/123902/

Comment 2

[Nathan Froyd [:froydnj]]

Comment on attachment 8851631 [details]
Bug 1350955 - Enable adaptive mutex usage on FreeBSD.

https://reviewboard.mozilla.org/r/123902/#review126404

Cool, I didn't know FreeBSD supported these.

::: mozglue/misc/Mutex_posix.cpp:30
(Diff revision 1)
>    // glibc's adaptive mutexes spin for a short number of tries before sleeping.
>    // NSPR's locks did this, too, and it seems like a reasonable thing to do.

Please modify this comment to read:

"Linux with glibc and FreedBSD support adaptive mutexes that spin for a short number of tries before sleeping.  NSPR's locks did this, too, and it seems like a reasonable thing to do."

Comment 3

[Jan Beich]

Comment on attachment 8851631 [details]
Bug 1350955 - Enable adaptive mutex usage on FreeBSD.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/123902/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f6fbee70b32c
Enable adaptive mutex usage on FreeBSD. r=froydnj

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f6fbee70b32c