Closed Bug 1350955 Opened 4 years ago Closed 4 years ago

Enable adaptive mutex on FreeBSD

Categories

(Core :: mozglue, enhancement)

Unspecified
FreeBSD
enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: jbeich, Unassigned)

References

Details

Attachments

(1 file)

PTHREAD_MUTEX_ADAPTIVE_NP is supported since FreeBSD 8.0. Getting patches accepted in NSPR is too hard: very few reviewers + a lot of cruft. I'll try but let's not block on that.

https://github.com/freebsd/freebsd/commit/bbfd76f8722c569a2be8de7fd01318fa54fa750c
Depends on: 1350966
Comment on attachment 8851631 [details]
Bug 1350955 - Enable adaptive mutex usage on FreeBSD.

https://reviewboard.mozilla.org/r/123902/#review126404

Cool, I didn't know FreeBSD supported these.

::: mozglue/misc/Mutex_posix.cpp:30
(Diff revision 1)
>    // glibc's adaptive mutexes spin for a short number of tries before sleeping.
>    // NSPR's locks did this, too, and it seems like a reasonable thing to do.

Please modify this comment to read:

"Linux with glibc and FreedBSD support adaptive mutexes that spin for a short number of tries before sleeping.  NSPR's locks did this, too, and it seems like a reasonable thing to do."
Attachment #8851631 - Flags: review?(nfroyd) → review+
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/f6fbee70b32c
Enable adaptive mutex usage on FreeBSD. r=froydnj
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/f6fbee70b32c
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.