1350959 - Implement bookmark repair strategy with desktop client for iOS

Status: RESOLVED FIXED

(Firefox for iOS :: Sync, enhancement, P1)

Description

[Stephan Leroux [:sleroux]]

After a sync operation but before we release the sync lock, 

1. Run validation on the bookmarks buffer on iOS to collect all of the structure/record IDs which are problematic. Rules for what constitutes a problematic record can be found here [1].

2. Choose a connected desktop Firefox client that is => 54 and is the one that most recently synced.

3. Send repairRequest command with problematic IDs, selected client, and flow ID.

To handle the monitoring of states between requests, we should create a state machine that keeps track of the repair's progress as it moves through the different clients. In addition to repairing, we'll also be threading telemetry events through each state transition which will be added the Sync Ping.

[1] http://searchfox.org/mozilla-central/rev/0079c7adf3b329bff579d3bbe6ac7ba2f6218a19/services/sync/modules/bookmark_repair.js#116-119,124-131,136-140,145-149,154-159,164-173

Comment 1

[Mark Hammond [:markh] [:mhammond]]

(In reply to Stephan Leroux [:sleroux] from comment #0)
> After a sync operation but before we release the sync lock, 
> 
> 1. Run validation on the bookmarks buffer on iOS to collect all of the
> structure/record IDs which are problematic. Rules for what constitutes a
> problematic record can be found here [1].

> [1]
> http://searchfox.org/mozilla-central/rev/
> 0079c7adf3b329bff579d3bbe6ac7ba2f6218a19/services/sync/modules/
> bookmark_repair.js#116-119,124-131,136-140,145-149,154-159,164-173

[1] is actually desktop's best-guess for what an iOS "can't enable bi-di sync" problem looks like. I think this is better described as something like "identify the IDs of bookmarks missing from the server which we believe will allow iOS to fully sync"

> 2. Choose a connected desktop Firefox client that is => 54 and is the one
> that most recently synced.
... and which hasn't previously been asked to perform this repair.

> 
> 3. Send repairRequest command with problematic IDs, selected client, and
> flow ID.

And: 4. Repeat from (2.) until we have no more clients to try.

Comment 2

[Edouard Oger [:eoger]]

Attachment: mozilla-mobile/firefox-ios#2702

Comment 3

[Edouard Oger [:eoger]]

Attachment: mozilla-mobile/firefox-ios#2724

Comment 4

[Stephan Leroux [:sleroux]]

master 1d2e055107902727ad88c1b6602d8948b9c4fb76

Currently disabled behind the merging bookmarks flag until we can get some event telemetry around this.