Closed Bug 1351031 Opened 3 years ago Closed 3 years ago

Update builders to rust 1.16.0

Categories

(Firefox Build System :: General, enhancement)

enhancement
Not set

Tracking

(firefox55 fixed)

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: rillian, Assigned: rillian)

Details

Attachments

(2 files)

Assignee: nobody → giles
Comment on attachment 8851784 [details]
Bug 1351031 - Update builders to rust 1.16.0.

https://reviewboard.mozilla.org/r/124006/#review127194
Attachment #8851784 - Flags: review?(mshal) → review+
Comment on attachment 8851785 [details]
Bug 1351031 - Update rust-build container.

https://reviewboard.mozilla.org/r/124008/#review127196

::: taskcluster/docker/rust-build/repack_rust.py:211
(Diff revision 1)
> +    else:
> +        return 'stable'
> +
>  if __name__ == '__main__':
> -    repack(mac64, [mac64, mac32])
> -    repack(win32, [win32])
> +    channel = args()
> +    repack(mac64, [mac64, mac32], channel=channel)

FYI, we no longer do universal OSX builds, so I believe you can skip mac32 here to make the toolchain smaller for mac builds (unless you need mac32 for other reasons?)

::: taskcluster/docker/rust-build/repack_rust.py:215
(Diff revision 1)
> -    repack(mac64, [mac64, mac32])
> -    repack(win32, [win32])
> -    repack(win64, [win64])
> -    repack(linux64, [linux64, linux32])
> -    repack(linux64, [linux64, mac64, mac32], suffix='mac-cross')
> -    repack(linux64, [linux64, android, android_x86], suffix='android-cross')
> +    channel = args()
> +    repack(mac64, [mac64, mac32], channel=channel)
> +    repack(win32, [win32], channel=channel)
> +    repack(win64, [win64], channel=channel)
> +    repack(linux64, [linux64, linux32], channel=channel)
> +    repack(linux64, [linux64, mac64, mac32],

mac32 again here can probably go away.
Attachment #8851785 - Flags: review?(mshal) → review+
Oops, I didn't mean to make those issues, but I can't seem to drop them myself - you don't need to fix them for this bug. Just informational in case you want to in a future bug :).
Comment on attachment 8851785 [details]
Bug 1351031 - Update rust-build container.

https://reviewboard.mozilla.org/r/124008/#review127196

> FYI, we no longer do universal OSX builds, so I believe you can skip mac32 here to make the toolchain smaller for mac builds (unless you need mac32 for other reasons?)

Good point, thanks! I'll drop it from the next test.
I forgot about the flake8 lint again. Fixup patch at https://pastebin.mozilla.org/8983541
Pushed by gszorc@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4303b5b80d1f
Fix flake8 failures in taskcluster/docker; r=me
Pushed by rgiles@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/735dd539dc73
Update builders to rust 1.16.0. r=mshal
https://hg.mozilla.org/integration/autoland/rev/c471a789673c
Update rust-build container. r=mshal
(In reply to Ralph Giles (:rillian) | needinfo me from comment #8)
> I forgot about the flake8 lint again. Fixup patch at
> https://pastebin.mozilla.org/8983541

Since pulsebot was down, I'm not sure if you wrote this patch first or if I did. In case you did, I wanted you to know that I didn't see your patch when I landed the fixup and wasn't trying to be passive aggressive or anything like that. When I mentioned the flake8 bustage in IRC, someone said it was this bug and I just stuck the bug number on the commit I had already made without much thought.

For the record, style lints are the worst. I wish local commits and/or autoland could reformat code to conform with style so minor test failures like this were avoidable.
No worries. Aryx pinged me on irc about the lint failure and I wrote a patch, but you landed yours before mine could be appended. I appreciated the fix and didn't feel stepped on. And as you point out, our two versions were identical.

Ideally, the decision task would schedule a lint task over whatever directories have relevant code changes. That would have caught the issue when I pushed to try.
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.