135105 - Context Menus: Bookmark This Page on image link menus

Status: NEW

(SeaMonkey :: UI Design, defect)

Description

[Hixie (not reading bugmail)]

STEPS TO REPRODUCE
   1. Open http://www.catcam.com/ .
   2. Right click on one of the blue image links.

ACTUAL RESULTS
   There is a lone page-related item on the menu.

EXPECTED RESULTS
   The "Bookmark This Page" item should go (or, its friends Save Page As and
   Send Page should be reinstated).

Using a Linux build from CVS tip with the menu changes on Mandrake 8.1.

Comment 1

[Paul Wyskoczka]

qa --> [e-mail]

Comment 2

[:deanis74]

I don't see why this portion of the context menu is different depending on
whether the link is an image or text.  The context menu produced by
right-clicking on the "Alcyone Systems" text link has all three page-related items.

Comment 3

[Blake Ross]

Please do not file "bugs" to me when you disagree with something in the spec.

Comment 4

[Jonathan Abbey]

Sorry, where is the context menu spec?

Comment 5

[:deanis74]

The spec is wrong in this case.  These two menu items appear and disappear
whether the image I'm right-clicking on is also a link.  This is not at all
intuitive.  They should either be there for all images or for none.

Comment 6

[Blake Ross]

Actually, I asked Marlon about this as well while I was implementing the spec,
and there was rationale behind this decision. I don't remember what it was
(Marlon can elaborate), but please don't assume it was an oversight.

Comment 7

[Hixie (not reading bugmail)]

Fair enough. It looks so silly I just assumed it was an implementation error.

Comment 8

[Jonas Jørgensen]

Very related (dupe?): Bug 144925, Image context menu should not refer to current
page.

Comment 9

[marlon bishop]

the user could mistakenly click on a rather large inline image that is
blanketing a page, yet it is not likely a large blanketing image would also be a
link.   most image as links are very deliberate and therefore are less ambiguous
in most circumstances.  For the case where the user intended to hit a page (no
finger cursor) but instead hit an image, he/she should be able to rely on
[bookmark this page], which is the most common way to store a page, without
having to search for open space.

Comment 10

[Jonas Jørgensen]

Marlon: Couldn't you say the same thing about back, forward, reload, stop, view
source, page info, save page and send page?

Comment 11

[Tony Mechelynck [:tonymec]]

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.1pre) Gecko/2008062801 SeaMonkey/2.0a1pre

Bug still present: "Save Page As" and "Send Page" are present on text links but not on image links. Whatever one could or couldn't say about the items mentioned in comment #10, these two menu items have nothing to do with whether the right-click happens on an image link or a text link (or indeed on something else than a link) so IMHO they should be always present (or maybe always absent).

Marlon: Are you still (reading bugmail and) working on this?

Comment 12

[Tony Mechelynck [:tonymec]]

No reply ro comment #11 => resetting AssignedTo to default.