1351074 - AsyncSpellCheckTestHelper.jsm should not be shipped

Status: RESOLVED FIXED

(Core :: DOM: Editor, enhancement, P3)

Description

[Florian Quèze [:florian]]

AsyncSpellCheckTestHelper.jsm, introduced by bug 856270, should be packaged using TESTING_JS_MODULES instead of EXTRA_JS_MODULES.

Comment 1

[Makoto Kato [:m_kato]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c73a85ac01e70c3fa08b84895d15299955a4f329

Comment 2

[Makoto Kato [:m_kato]]

reftest (reftest-content.js) cannot load resource://testing-common/*, so we cannot move this to TESTING_JS_MODULES easily.

Comment 3

[Makoto Kato [:m_kato]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5adbe114ada3f9c8fb0d42a15e227bd57303fac6

Comment 4

[Makoto Kato [:m_kato]]

Attachment: Bug 1351074 - Part 1. AsyncSpellCheckTestHelper.jsm should not be shipped.

AsyncSpellCheckTestHelper.jsm uses on mochitest and reftest, so we shouldn't be shipped in release package

Review commit: https://reviewboard.mozilla.org/r/125316/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/125316/

Comment 5

[Makoto Kato [:m_kato]]

Attachment: Bug 1351074 - Part 2. Use testing-common for AsyncSpellCheckTestHelper.jsm.

TESTING_JS_MODULES uses testing-common, not gre.  So we should replace gre with testing-common for mochitest.

Review commit: https://reviewboard.mozilla.org/r/125318/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/125318/

Comment 6

[Makoto Kato [:m_kato]]

Attachment: Bug 1351074 - Part 3. Include AsyncSpellCheckTestHelper.jsm in reftest.

reftest cannot use testing-common, so we should include AsyncSpellCheckTestHelper.jsm in reftest.jar.

Review commit: https://reviewboard.mozilla.org/r/125320/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/125320/

Comment 7

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8853255 [details]
Bug 1351074 - Part 1. AsyncSpellCheckTestHelper.jsm should not be shipped.

https://reviewboard.mozilla.org/r/125316/#review127920

::: commit-message-8df9f:3
(Diff revision 1)
> +Bug 1351074 - Part 1. AsyncSpellCheckTestHelper.jsm should not be shipped. r?masayuki
> +
> +AsyncSpellCheckTestHelper.jsm uses on mochitest and reftest, so we shouldn't be shipped in release package

s/shouldn'tbe shipped/shouldn't ship it

Comment 8

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8853256 [details]
Bug 1351074 - Part 2. Use testing-common for AsyncSpellCheckTestHelper.jsm.

https://reviewboard.mozilla.org/r/125318/#review127922

Comment 9

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8853257 [details]
Bug 1351074 - Part 3. Include AsyncSpellCheckTestHelper.jsm in reftest.

https://reviewboard.mozilla.org/r/125320/#review127924

Comment 10

[Makoto Kato [:m_kato]]

Comment on attachment 8853255 [details]
Bug 1351074 - Part 1. AsyncSpellCheckTestHelper.jsm should not be shipped.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/125316/diff/1-2/

Comment 11

[Makoto Kato [:m_kato]]

Comment on attachment 8853256 [details]
Bug 1351074 - Part 2. Use testing-common for AsyncSpellCheckTestHelper.jsm.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/125318/diff/1-2/

Comment 12

[Makoto Kato [:m_kato]]

Comment on attachment 8853257 [details]
Bug 1351074 - Part 3. Include AsyncSpellCheckTestHelper.jsm in reftest.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/125320/diff/1-2/

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/586428f69838
Part 1. AsyncSpellCheckTestHelper.jsm should not be shipped. r=masayuki
https://hg.mozilla.org/integration/autoland/rev/4fdf3b87a70b
Part 2. Use testing-common for AsyncSpellCheckTestHelper.jsm. r=masayuki
https://hg.mozilla.org/integration/autoland/rev/941e0f9ff9a7
Part 3. Include AsyncSpellCheckTestHelper.jsm in reftest. r=masayuki

Comment 14

[Phil Ringnalda (:philor)]

Backed out in https://hg.mozilla.org/integration/autoland/rev/902c52628071 - reftest harness said https://treeherder.mozilla.org/logviewer.html#?job_id=88206528&repo=autoland and browser_all_files_referenced.js said https://treeherder.mozilla.org/logviewer.html#?job_id=88206054&repo=autoland

Comment 15

[Makoto Kato [:m_kato]]

Attachment: Bug 1351074 - Part 4. Remove AsyncSpellCheckTestHelper.jsm from whitelist.

Since AsyncSpellCheckTestHelper.jsm is test only file, so we have to remove it from whitelist.

Review commit: https://reviewboard.mozilla.org/r/125926/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/125926/

Comment 16

[Makoto Kato [:m_kato]]

Comment on attachment 8853255 [details]
Bug 1351074 - Part 1. AsyncSpellCheckTestHelper.jsm should not be shipped.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/125316/diff/2-3/

Comment 17

[Makoto Kato [:m_kato]]

Comment on attachment 8853256 [details]
Bug 1351074 - Part 2. Use testing-common for AsyncSpellCheckTestHelper.jsm.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/125318/diff/2-3/

Comment 18

[Makoto Kato [:m_kato]]

Comment on attachment 8853257 [details]
Bug 1351074 - Part 3. Include AsyncSpellCheckTestHelper.jsm in reftest.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/125320/diff/2-3/

Comment 19

[Makoto Kato [:m_kato]]

Comment on attachment 8853257 [details]
Bug 1351074 - Part 3. Include AsyncSpellCheckTestHelper.jsm in reftest.

I have a typo for chrome://

Comment 20

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8853257 [details]
Bug 1351074 - Part 3. Include AsyncSpellCheckTestHelper.jsm in reftest.

https://reviewboard.mozilla.org/r/125320/#review128430

Comment 21

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8853891 [details]
Bug 1351074 - Part 4. Remove AsyncSpellCheckTestHelper.jsm from whitelist.

https://reviewboard.mozilla.org/r/125926/#review128432

Comment 22

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/970621161262
Part 1. AsyncSpellCheckTestHelper.jsm should not be shipped. r=masayuki
https://hg.mozilla.org/integration/autoland/rev/0db365ebfa26
Part 2. Use testing-common for AsyncSpellCheckTestHelper.jsm. r=masayuki
https://hg.mozilla.org/integration/autoland/rev/aecf46456a60
Part 3. Include AsyncSpellCheckTestHelper.jsm in reftest. r=masayuki
https://hg.mozilla.org/integration/autoland/rev/aaecf2dd1548
Part 4. Remove AsyncSpellCheckTestHelper.jsm from whitelist. r=masayuki

Comment 23

[Makoto Kato [:m_kato]]

Need touch CLOBBER due to bug 1352982 :-<

Comment 24

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/916a4ee676a3
followup, touch CLOBBER to really get AsyncSpellCheckTestHelper.jsm removed

Comment 25

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/970621161262
https://hg.mozilla.org/mozilla-central/rev/0db365ebfa26
https://hg.mozilla.org/mozilla-central/rev/aecf46456a60
https://hg.mozilla.org/mozilla-central/rev/aaecf2dd1548
https://hg.mozilla.org/mozilla-central/rev/916a4ee676a3