Closed
Bug 1351074
Opened 7 years ago
Closed 7 years ago
AsyncSpellCheckTestHelper.jsm should not be shipped
Categories
(Core :: DOM: Editor, enhancement, P3)
Core
DOM: Editor
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: florian, Assigned: m_kato)
References
Details
Attachments
(4 files)
AsyncSpellCheckTestHelper.jsm, introduced by bug 856270, should be packaged using TESTING_JS_MODULES instead of EXTRA_JS_MODULES.
|
Assignee | |
Updated•7 years ago
|
Priority: -- → P3
|
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → m_kato
|
|
Assignee | |
Comment 1•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c73a85ac01e70c3fa08b84895d15299955a4f329
|
|
Assignee | |
Comment 2•7 years ago
|
||
reftest (reftest-content.js) cannot load resource://testing-common/*, so we cannot move this to TESTING_JS_MODULES easily.
|
|
Assignee | |
Comment 3•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=5adbe114ada3f9c8fb0d42a15e227bd57303fac6
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
||
Comment 7•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8853255 [details] Bug 1351074 - Part 1. AsyncSpellCheckTestHelper.jsm should not be shipped. https://reviewboard.mozilla.org/r/125316/#review127920 ::: commit-message-8df9f:3 (Diff revision 1) > +Bug 1351074 - Part 1. AsyncSpellCheckTestHelper.jsm should not be shipped. r?masayuki > + > +AsyncSpellCheckTestHelper.jsm uses on mochitest and reftest, so we shouldn't be shipped in release package s/shouldn'tbe shipped/shouldn't ship it
Attachment #8853255 -
Flags: review?(masayuki) → review+
|
|
||
Comment 8•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8853256 [details] Bug 1351074 - Part 2. Use testing-common for AsyncSpellCheckTestHelper.jsm. https://reviewboard.mozilla.org/r/125318/#review127922
Attachment #8853256 -
Flags: review?(masayuki) → review+
|
|
||
Comment 9•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8853257 [details] Bug 1351074 - Part 3. Include AsyncSpellCheckTestHelper.jsm in reftest. https://reviewboard.mozilla.org/r/125320/#review127924
Attachment #8853257 -
Flags: review?(masayuki) → review+
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
||
Comment 13•7 years ago
|
||
Pushed by m_kato@ga2.so-net.ne.jp: https://hg.mozilla.org/integration/autoland/rev/586428f69838 Part 1. AsyncSpellCheckTestHelper.jsm should not be shipped. r=masayuki https://hg.mozilla.org/integration/autoland/rev/4fdf3b87a70b Part 2. Use testing-common for AsyncSpellCheckTestHelper.jsm. r=masayuki https://hg.mozilla.org/integration/autoland/rev/941e0f9ff9a7 Part 3. Include AsyncSpellCheckTestHelper.jsm in reftest. r=masayuki
|
||
Comment 14•7 years ago
|
||
Backed out in https://hg.mozilla.org/integration/autoland/rev/902c52628071 - reftest harness said https://treeherder.mozilla.org/logviewer.html#?job_id=88206528&repo=autoland and browser_all_files_referenced.js said https://treeherder.mozilla.org/logviewer.html#?job_id=88206054&repo=autoland
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Comment 19•7 years ago
|
||
Comment on attachment 8853257 [details] Bug 1351074 - Part 3. Include AsyncSpellCheckTestHelper.jsm in reftest. I have a typo for chrome://
Attachment #8853257 -
Flags: review+ → review?(masayuki)
|
|
||
Comment 20•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8853257 [details] Bug 1351074 - Part 3. Include AsyncSpellCheckTestHelper.jsm in reftest. https://reviewboard.mozilla.org/r/125320/#review128430
Attachment #8853257 -
Flags: review?(masayuki) → review+
|
|
||
Comment 21•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8853891 [details] Bug 1351074 - Part 4. Remove AsyncSpellCheckTestHelper.jsm from whitelist. https://reviewboard.mozilla.org/r/125926/#review128432
Attachment #8853891 -
Flags: review?(masayuki) → review+
|
|
||
Comment 22•7 years ago
|
||
Pushed by m_kato@ga2.so-net.ne.jp: https://hg.mozilla.org/integration/autoland/rev/970621161262 Part 1. AsyncSpellCheckTestHelper.jsm should not be shipped. r=masayuki https://hg.mozilla.org/integration/autoland/rev/0db365ebfa26 Part 2. Use testing-common for AsyncSpellCheckTestHelper.jsm. r=masayuki https://hg.mozilla.org/integration/autoland/rev/aecf46456a60 Part 3. Include AsyncSpellCheckTestHelper.jsm in reftest. r=masayuki https://hg.mozilla.org/integration/autoland/rev/aaecf2dd1548 Part 4. Remove AsyncSpellCheckTestHelper.jsm from whitelist. r=masayuki
|
|
Assignee | |
Comment 23•7 years ago
|
||
Need touch CLOBBER due to bug 1352982 :-<
|
|
||
Comment 24•7 years ago
|
||
Pushed by philringnalda@gmail.com: https://hg.mozilla.org/integration/autoland/rev/916a4ee676a3 followup, touch CLOBBER to really get AsyncSpellCheckTestHelper.jsm removed
|
||
Comment 25•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/970621161262 https://hg.mozilla.org/mozilla-central/rev/0db365ebfa26 https://hg.mozilla.org/mozilla-central/rev/aecf46456a60 https://hg.mozilla.org/mozilla-central/rev/aaecf2dd1548 https://hg.mozilla.org/mozilla-central/rev/916a4ee676a3
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•