Closed Bug 1351074 Opened 3 years ago Closed 3 years ago

AsyncSpellCheckTestHelper.jsm should not be shipped

Categories

(Core :: DOM: Editor, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: florian, Assigned: m_kato)

References

Details

Attachments

(4 files)

AsyncSpellCheckTestHelper.jsm, introduced by bug 856270, should be packaged using TESTING_JS_MODULES instead of EXTRA_JS_MODULES.
Priority: -- → P3
Assignee: nobody → m_kato
reftest (reftest-content.js) cannot load resource://testing-common/*, so we cannot move this to TESTING_JS_MODULES easily.
Comment on attachment 8853255 [details]
Bug 1351074 - Part 1. AsyncSpellCheckTestHelper.jsm should not be shipped.

https://reviewboard.mozilla.org/r/125316/#review127920

::: commit-message-8df9f:3
(Diff revision 1)
> +Bug 1351074 - Part 1. AsyncSpellCheckTestHelper.jsm should not be shipped. r?masayuki
> +
> +AsyncSpellCheckTestHelper.jsm uses on mochitest and reftest, so we shouldn't be shipped in release package

s/shouldn'tbe shipped/shouldn't ship it
Attachment #8853255 - Flags: review?(masayuki) → review+
Comment on attachment 8853256 [details]
Bug 1351074 - Part 2. Use testing-common for AsyncSpellCheckTestHelper.jsm.

https://reviewboard.mozilla.org/r/125318/#review127922
Attachment #8853256 - Flags: review?(masayuki) → review+
Comment on attachment 8853257 [details]
Bug 1351074 - Part 3. Include AsyncSpellCheckTestHelper.jsm in reftest.

https://reviewboard.mozilla.org/r/125320/#review127924
Attachment #8853257 - Flags: review?(masayuki) → review+
Pushed by m_kato@ga2.so-net.ne.jp:
https://hg.mozilla.org/integration/autoland/rev/586428f69838
Part 1. AsyncSpellCheckTestHelper.jsm should not be shipped. r=masayuki
https://hg.mozilla.org/integration/autoland/rev/4fdf3b87a70b
Part 2. Use testing-common for AsyncSpellCheckTestHelper.jsm. r=masayuki
https://hg.mozilla.org/integration/autoland/rev/941e0f9ff9a7
Part 3. Include AsyncSpellCheckTestHelper.jsm in reftest. r=masayuki
Comment on attachment 8853257 [details]
Bug 1351074 - Part 3. Include AsyncSpellCheckTestHelper.jsm in reftest.

I have a typo for chrome://
Attachment #8853257 - Flags: review+ → review?(masayuki)
Comment on attachment 8853257 [details]
Bug 1351074 - Part 3. Include AsyncSpellCheckTestHelper.jsm in reftest.

https://reviewboard.mozilla.org/r/125320/#review128430
Attachment #8853257 - Flags: review?(masayuki) → review+
Comment on attachment 8853891 [details]
Bug 1351074 - Part 4. Remove AsyncSpellCheckTestHelper.jsm from whitelist.

https://reviewboard.mozilla.org/r/125926/#review128432
Attachment #8853891 - Flags: review?(masayuki) → review+
Pushed by m_kato@ga2.so-net.ne.jp:
https://hg.mozilla.org/integration/autoland/rev/970621161262
Part 1. AsyncSpellCheckTestHelper.jsm should not be shipped. r=masayuki
https://hg.mozilla.org/integration/autoland/rev/0db365ebfa26
Part 2. Use testing-common for AsyncSpellCheckTestHelper.jsm. r=masayuki
https://hg.mozilla.org/integration/autoland/rev/aecf46456a60
Part 3. Include AsyncSpellCheckTestHelper.jsm in reftest. r=masayuki
https://hg.mozilla.org/integration/autoland/rev/aaecf2dd1548
Part 4. Remove AsyncSpellCheckTestHelper.jsm from whitelist. r=masayuki
Need touch CLOBBER due to bug 1352982 :-<
Depends on: 1352982
Pushed by philringnalda@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/916a4ee676a3
followup, touch CLOBBER to really get AsyncSpellCheckTestHelper.jsm removed
You need to log in before you can comment on or make changes to this bug.