1351089 - Remove unused resource://gre/modules/PresentationDeviceInfoManager.jsm

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P3)

Description

[Florian Quèze [:florian]]

This was added in bug 1080474, and is only referenced at http://searchfox.org/mozilla-central/rev/7419b368156a6efa24777b21b0e5706be89a9c2f/b2g/chrome/content/shell.js#26

There may be a lot more things to remove from dom/presentation/, as it's not really clear to me if this code was ever used outside of b2g (dom.presentation.enabled is true for android, but it seems that was added as part of the same patch).

Comment 1

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Maybe S.C. has something to comment on this usage.

Comment 2

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

PresentationDeviceInfoManager.jsm is something we can removed from the code base.
dom/presentation includes two API: Presentation API and Presentation Device Info API.
Presentation API is currently used in Fennec but Device Info API is B2G chrome-only API.

Here is the list of file that can be removed:
dom/webidl/PresentationDeviceInfoManager.webidl
dom/presentation/PresentationDeviceInfoManager.js
dom/presentation/PresentationDeviceInfoManager.jsm
dom/presentation/PresentationDeviceInfoManager.manifest
dom/presentation/tests/mochitest/test_presentation_device_info_permission.html
dom/presentation/tests/mochitest/test_presentation_device_info.html

Files that references to these files will also need corresponding modification.

@flo, what's the priority and impact of this bug?

Comment 3

[Florian Quèze [:florian]]

(In reply to Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz) from comment #2)

> @flo, what's the priority and impact of this bug?

The impact is reducing the size of the Firefox builds we ship. The priority would be the same as other bugs blocking bug 1306391.

Comment 4

[Dan Banner]

Attachment: Bug 1351089 - Remove unused PresentationDeviceInfoManager.jsm

Review commit: https://reviewboard.mozilla.org/r/141896/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/141896/

Comment 5

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

Comment on attachment 8870457 [details]
Bug 1351089 - Remove unused PresentationDeviceInfoManager.jsm

https://reviewboard.mozilla.org/r/141896/#review145770

Thanks for working on this! However, this patch is still far away from r+.
Here is the list of things you should notice:
1. Only files I mentioned in comment #2 should be removed. Other files should be kept and fixed.
2. You'll need to make sure the rest of Presetation API tests are passed, and these test cases are writen in both e10s and non-e10s mochitest. When you do local test please make sure you run both `./mach mochitest dom/presentation` and `./mach mochitest --disable-e10s dom/presentation`.

Comment 6

[Dan Banner]

Comment on attachment 8870457 [details]
Bug 1351089 - Remove unused PresentationDeviceInfoManager.jsm

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/141896/diff/1-2/

Comment 7

[Dan Banner]

Comment on attachment 8870457 [details]
Bug 1351089 - Remove unused PresentationDeviceInfoManager.jsm

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/141896/diff/2-3/

Comment 8

[Dan Banner]

Comment on attachment 8870457 [details]
Bug 1351089 - Remove unused PresentationDeviceInfoManager.jsm

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/141896/diff/3-4/

Comment 9

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

Comment on attachment 8870457 [details]
Bug 1351089 - Remove unused PresentationDeviceInfoManager.jsm

https://reviewboard.mozilla.org/r/141896/#review159762

Doing a quick DXR search and find some more files to modified.
- tools/lint/eslint/modules.json
- mobile/android/installer/package-manifest.in
- dom/tests/mochitest/general/test_interfaces.js
You'll need to add @smaug in the reviewer list since modifying test_interfaces.js requires a DOM peer review.

Comment 10

[Dan Banner]

Comment on attachment 8870457 [details]
Bug 1351089 - Remove unused PresentationDeviceInfoManager.jsm

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/141896/diff/4-5/

Comment 11

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8870457 [details]
Bug 1351089 - Remove unused PresentationDeviceInfoManager.jsm

https://reviewboard.mozilla.org/r/141896/#review160322

r+ for the .webidl and test_interfaces.js

Comment 12

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

Comment on attachment 8870457 [details]
Bug 1351089 - Remove unused PresentationDeviceInfoManager.jsm

https://reviewboard.mozilla.org/r/141896/#review160442

Thanks!

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1f16321b2fff
Remove unused PresentationDeviceInfoManager.jsm r=schien,smaug

Comment 14

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/1f16321b2fff

Comment 15

[Ionuț Goldan [:igoldan]]

This bug removed some of the compiler warnings. Thank you!

== Change summary for alert #7763 (as of July 08 2017 08:21 UTC) ==

Improvements:

  2%  compiler warnings summary linux64 pgo      1,351.50 -> 1,330.83

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=7763