1351116 - github issue links are not expanded in parentheses

Status: NEW

(bugzilla.mozilla.org :: Extensions, defect)

Description

[Ralph Giles (:rillian)]

The new github issue-linking feature seems to be confused by non-url punctuation.

This gets a hyperlink: rust-lang/rust#40482
This does not: (rust-lang/rust#40482)

Note that `(` is not a valid character for github repository names. It would be nice to adjust the recognizer to handle this putting references in brackets is fairly common.

Comment 3

[Kohei Yoshino [:kohei]]

Attachment: GitHub Pull Request

Comment 4

[Kohei Yoshino [:kohei]]

Merged to master.

Comment 5

[Kartikaya Gupta (email:[e-mail])]

I think this patch might have been overzealous. Now searchfox links are getting mangled. See for example the link at https://bugzilla.mozilla.org/show_bug.cgi?id=1508801#c0 - in the bugmail I got the end of that link is correctly shown as "src/shade.rs#160" but when viewing it on bugzilla the link is corrupted.

Comment 6

[Dylan Hardison [:dylan] (he/him)]

We'll back this out and have it fixed tomorrow.

Comment 7

[Dylan Hardison [:dylan] (he/him)]

backed out *or* fixed, that is

Comment 8

[Kohei Yoshino [:kohei]]

Hmm, my bad. To avoid such cases, we should probably check if there’s no slash before `\b`.

Comment 9

[Kohei Yoshino [:kohei]]

Attachment: GitHub Pull Request to fix wrong linkification

Comment 10

[Kohei Yoshino [:kohei]]

The follow-up PR merged to master. Should go live tomorrow.

Comment 11

[Kohei Yoshino [:kohei]]

The PR has been backed out in Bug 1508912. Need a better strategy here. We even don’t have unit tests for comment rendering so regressions can happen easily. Personally I’m not sure if we need this specific GitHub issue/PR linkification.