github issue links are not expanded in parentheses

NEW
Unassigned

Status

()

2 years ago
4 months ago

People

(Reporter: rillian, Unassigned)

Tracking

Production

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

The new github issue-linking feature seems to be confused by non-url punctuation.

This gets a hyperlink: rust-lang/rust#40482
This does not: (rust-lang/rust#40482)

Note that `(` is not a valid character for github repository names. It would be nice to adjust the recognizer to handle this putting references in brackets is fairly common.
Posted file GitHub Pull Request
Assignee: nobody → kohei.yoshino
Status: NEW → ASSIGNED
Component: General → Extensions: BMO
Merged to master.
Status: ASSIGNED → RESOLVED
Last Resolved: 4 months ago
Resolution: --- → FIXED
I think this patch might have been overzealous. Now searchfox links are getting mangled. See for example the link at https://bugzilla.mozilla.org/show_bug.cgi?id=1508801#c0 - in the bugmail I got the end of that link is correctly shown as "src/shade.rs#160" but when viewing it on bugzilla the link is corrupted.
Flags: needinfo?(kohei.yoshino)
We'll back this out and have it fixed tomorrow.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
backed out *or* fixed, that is
Hmm, my bad. To avoid such cases, we should probably check if there’s no slash before `\b`.
Status: REOPENED → ASSIGNED
Flags: needinfo?(kohei.yoshino)
The follow-up PR merged to master. Should go live tomorrow.
Status: ASSIGNED → RESOLVED
Last Resolved: 4 months ago4 months ago
Resolution: --- → FIXED
The PR has been backed out in Bug 1508912. Need a better strategy here. We even don’t have unit tests for comment rendering so regressions can happen easily. Personally I’m not sure if we need this specific GitHub issue/PR linkification.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee: kohei.yoshino → nobody
Status: REOPENED → NEW
You need to log in before you can comment on or make changes to this bug.