Open
Bug 1351116
Opened 7 years ago
Updated 2 years ago
github issue links are not expanded in parentheses
Categories
(bugzilla.mozilla.org :: Extensions, defect)
Tracking
()
NEW
People
(Reporter: rillian, Unassigned)
References
Details
Attachments
(2 files)
The new github issue-linking feature seems to be confused by non-url punctuation. This gets a hyperlink: rust-lang/rust#40482 This does not: (rust-lang/rust#40482) Note that `(` is not a valid character for github repository names. It would be nice to adjust the recognizer to handle this putting references in brackets is fairly common.
Comment 3•6 years ago
|
||
Assignee: nobody → kohei.yoshino
Status: NEW → ASSIGNED
Updated•6 years ago
|
Component: General → Extensions: BMO
Comment 4•6 years ago
|
||
Merged to master.
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Comment 5•6 years ago
|
||
I think this patch might have been overzealous. Now searchfox links are getting mangled. See for example the link at https://bugzilla.mozilla.org/show_bug.cgi?id=1508801#c0 - in the bugmail I got the end of that link is correctly shown as "src/shade.rs#160" but when viewing it on bugzilla the link is corrupted.
Flags: needinfo?(kohei.yoshino)
Comment 6•6 years ago
|
||
We'll back this out and have it fixed tomorrow.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 7•6 years ago
|
||
backed out *or* fixed, that is
Comment 8•6 years ago
|
||
Hmm, my bad. To avoid such cases, we should probably check if there’s no slash before `\b`.
Status: REOPENED → ASSIGNED
Flags: needinfo?(kohei.yoshino)
Comment 9•6 years ago
|
||
Comment 10•6 years ago
|
||
The follow-up PR merged to master. Should go live tomorrow.
Status: ASSIGNED → RESOLVED
Closed: 6 years ago → 6 years ago
Resolution: --- → FIXED
Comment 11•6 years ago
|
||
The PR has been backed out in Bug 1508912. Need a better strategy here. We even don’t have unit tests for comment rendering so regressions can happen easily. Personally I’m not sure if we need this specific GitHub issue/PR linkification.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Updated•6 years ago
|
Assignee: kohei.yoshino → nobody
Status: REOPENED → NEW
Updated•5 years ago
|
Component: Extensions: BMO → Extensions
You need to log in
before you can comment on or make changes to this bug.
Description
•