1351139 - Use only one kind of anonymous box for the block parts of an {ib} (block inside inline) split

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[Boris Zbarsky [:bzbarsky]]

Right now we have different anonymous boxes depending on whether the inline is positioned or not, but we don't actually need to do that.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Bug 1351139. Use only one kind of anonymous box for the block wrappers we create for a block-inside-inline split.

Review commit: https://reviewboard.mozilla.org/r/124070/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/124070/

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8851858 [details]
Bug 1351139.  Use only one kind of anonymous box for the block wrappers we create for a block-inside-inline split.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/124070/diff/1-2/

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 8851858 [details]
Bug 1351139.  Use only one kind of anonymous box for the block wrappers we create for a block-inside-inline split.

https://reviewboard.mozilla.org/r/124070/#review126798

I guess atom_macro.rs regeneration picked up some other changes as well?  (It would be nice if the "AUTOGENERATED FILE" comment at the top said what generated it!)

Anyway, r=dbaron

Comment 4

[Boris Zbarsky [:bzbarsky]]

> I guess atom_macro.rs regeneration picked up some other changes as well?

Yep.  Basically, it _should_ be regenerated any time our atoms change, but in practice only happens for the ones servo actually uses, because that causes link failures.

> It would be nice if the "AUTOGENERATED FILE" comment at the top said what generated it!

servo/components/style/binding_tools/regen_atoms.py

I'll get that added to the comment.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8851858 [details]
Bug 1351139.  Use only one kind of anonymous box for the block wrappers we create for a block-inside-inline split.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/124070/diff/2-3/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ad39b0e99338
Use only one kind of anonymous box for the block wrappers we create for a block-inside-inline split.  r=dbaron

Comment 7

[Mats Palmgren (inactive)]

Did you intentionally remove the 'clip' property?
FYI, typo in ua.css: "have an effect it it's not".

Comment 8

[Mats Palmgren (inactive)]

Ah, nevermind, saw your commit message now... I should go to bed :-)

Comment 9

[Boris Zbarsky [:bzbarsky]]

> FYI, typo in ua.css: "have an effect it it's not".

Will fix, thanks!

And yes, I removed "clip" on purpose.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8822191ed166
followup: fix typo that Mats noticed.  r=typo, DONTBUILD

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ad39b0e99338
https://hg.mozilla.org/mozilla-central/rev/8822191ed166