Closed Bug 1351425 Opened 3 years ago Closed 3 years ago

Disable DevTools e10s cohort manipulation for when e10s is 100% enabled

Categories

(DevTools :: General, defect, P1)

defect

Tracking

(firefox52 unaffected, firefox53 fixed, firefox54 fixed, firefox55 fixed)

RESOLVED FIXED
Firefox 55
Tracking Status
firefox52 --- unaffected
firefox53 --- fixed
firefox54 --- fixed
firefox55 --- fixed

People

(Reporter: jryans, Assigned: jryans)

References

Details

Attachments

(2 files)

In bug 1342490, we modified e10s cohort selection so that DevTools users always enable e10s, and they are always put to the "temp-qualified-devtools" cohort (no matter what would have happened by default with test vs. control groups).

With release and esr channels (where e10s is enabled for 100% of the population that qualifies), it adds noise to the cohort metrics to label some users as devtools qualified when they would have qualified anyway.
Comment on attachment 8852209 [details]
Bug 1351425 - Only temp. qualify for e10s when enabled at <100%.

https://reviewboard.mozilla.org/r/124438/#review127070
Attachment #8852209 - Flags: review?(felipc) → review+
Comment on attachment 8852210 [details]
Bug 1351425 - Bump e10srollout to version 1.13.

https://reviewboard.mozilla.org/r/124440/#review127072
Attachment #8852210 - Flags: review?(felipc) → review+
Pushed by felipc@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/607da5b86b8a
Only temp. qualify for e10s when enabled at <100%. r=Felipe
(I squashed the version bump to land it as one patch)
Comment on attachment 8852209 [details]
Bug 1351425 - Only temp. qualify for e10s when enabled at <100%.

Approval Request Comment
[Feature/Bug causing the regression]: This patch softens the change done by bug 1342490 to avoid an unnecessary change of cohort name for release users.
[User impact if declined]: Some release users will have their e10s cohort tag changed from "test" to "devtools", which we want to avoid.
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Doesn't apply to nightly
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: no
[Why is the change risky/not risky?]: It's a simple change
[String changes made/needed]: none
Attachment #8852209 - Flags: approval-mozilla-beta?
Attachment #8852209 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/607da5b86b8a
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Hi Felipe, is this just a renaming or regrouping of e10s enabled users into cohorts? Or is this enabling e10s on a larger cohort?

NI Liz, if this is a good thing to do, perhaps including it in today's beta build might be a good idea.
Flags: needinfo?(lhenry)
Flags: needinfo?(felipc)
Comment on attachment 8852209 [details]
Bug 1351425 - Only temp. qualify for e10s when enabled at <100%.

Getting 53 up to date with the addons/e10s whitelist.
Attachment #8852209 - Flags: approval-mozilla-beta?
Attachment #8852209 - Flags: approval-mozilla-beta+
Attachment #8852209 - Flags: approval-mozilla-aurora?
Attachment #8852209 - Flags: approval-mozilla-aurora+
(In reply to Ritu Kothari (:ritu) from comment #9)
> Hi Felipe, is this just a renaming or regrouping of e10s enabled users into
> cohorts? Or is this enabling e10s on a larger cohort?

This is just a renaming, it doesn't get e10s to more or less people..  Actually this patch avoids a rename: without it some e10s users would be tagged "devtools" instead of "test".  Nothing in practice would change for them, but it helps our data analysis to not take users out of "test".
Flags: needinfo?(lhenry)
Flags: needinfo?(felipc)
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.