1351425 - Disable DevTools e10s cohort manipulation for when e10s is 100% enabled

Status: RESOLVED FIXED

(DevTools :: General, defect, P1)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

In bug 1342490, we modified e10s cohort selection so that DevTools users always enable e10s, and they are always put to the "temp-qualified-devtools" cohort (no matter what would have happened by default with test vs. control groups).

With release and esr channels (where e10s is enabled for 100% of the population that qualifies), it adds noise to the cohort metrics to label some users as devtools qualified when they would have qualified anyway.

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: Bug 1351425 - Only temp. qualify for e10s when enabled at <100%.

This tweaks the temporary qualification step (currently used only for DevTools)
so that it does not apply on channels that are 100% enabled anyway.  This does
not change how many users receive e10s on, it only tweaks who falls into which
cohort, since there's no reason to push all DevTools users to a special cohort
if everyone would have received e10s on anyway.

Review commit: https://reviewboard.mozilla.org/r/124438/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/124438/

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: Bug 1351425 - Bump e10srollout to version 1.13.

Review commit: https://reviewboard.mozilla.org/r/124440/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/124440/

Comment 3

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8852209 [details]
Bug 1351425 - Only temp. qualify for e10s when enabled at <100%.

https://reviewboard.mozilla.org/r/124438/#review127070

Comment 4

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8852210 [details]
Bug 1351425 - Bump e10srollout to version 1.13.

https://reviewboard.mozilla.org/r/124440/#review127072

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/607da5b86b8a
Only temp. qualify for e10s when enabled at <100%. r=Felipe

Comment 6

[:Felipe Gomes (needinfo for replies!)]

(I squashed the version bump to land it as one patch)

Comment 7

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8852209 [details]
Bug 1351425 - Only temp. qualify for e10s when enabled at <100%.

Approval Request Comment
[Feature/Bug causing the regression]: This patch softens the change done by bug 1342490 to avoid an unnecessary change of cohort name for release users.
[User impact if declined]: Some release users will have their e10s cohort tag changed from "test" to "devtools", which we want to avoid.
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Doesn't apply to nightly
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: no
[Why is the change risky/not risky?]: It's a simple change
[String changes made/needed]: none

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/607da5b86b8a

Comment 9

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Hi Felipe, is this just a renaming or regrouping of e10s enabled users into cohorts? Or is this enabling e10s on a larger cohort?

NI Liz, if this is a good thing to do, perhaps including it in today's beta build might be a good idea.

Comment 10

[Liz Henry (:lizzard)]

Comment on attachment 8852209 [details]
Bug 1351425 - Only temp. qualify for e10s when enabled at <100%.

Getting 53 up to date with the addons/e10s whitelist.

Comment 11

[:Felipe Gomes (needinfo for replies!)]

(In reply to Ritu Kothari (:ritu) from comment #9)
> Hi Felipe, is this just a renaming or regrouping of e10s enabled users into
> cohorts? Or is this enabling e10s on a larger cohort?

This is just a renaming, it doesn't get e10s to more or less people..  Actually this patch avoids a rename: without it some e10s users would be tagged "devtools" instead of "test".  Nothing in practice would change for them, but it helps our data analysis to not take users out of "test".

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-beta/rev/9a91487812d6

Comment 13

[:Felipe Gomes (needinfo for replies!)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/d25fba4383a6