135148 - gDBView.selectMsgByKey always includes the currently displayed message

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[[e-mail]]

This doesn't look as if it's by design, and there's nowhere that it's currently
used so it doesn't show up yet, but selectMsgByKey selects the currently
displayed message as well as the given message. And I don't know an easy way to
clear the currently displayed message except by using
outlinerSelection.clearSelection();
outlinerView.selectionChanged();

I was trying to use this to save the key to select after a delete, because of
the problem with right-clicking a message after the current index to IMAP delete it.

Comment 1

[[e-mail]]

Attachment: Proposed Patch

This seems to me as if it should work, but I can't test C++ changes :-(

Comment 2

[Håkan Waara]

Neil, where are you using this function from?  We might have logic in the
dbview, that would be automagically invoked if someone used this from within
mailnews.

Comment 3

[Sean Su]

added David to the CC: list since he's a DBView expert.

Comment 4

[David :Bienvenu]

I think Seth and Navin were most recently involved in this save and restore
selection handling. This fix does look right to me, in the sense that we don't
want the ::RestoreSelection code to be doing what it's doing with
m_currentlyDisplayedMsgKey. The alternative is to fix ::RestoreSelection to only
do what it's doing when m_currentlyDisplayedMsgKey is in aMsgKeyArray - it seems
like it would be wrong to do what it's doing when m_currentlyDisplayedMsgKey is
not in aMsgKeyArray

Comment 5

[[e-mail]]

As I understand it save/restore selection is used for switching between
normal/threaded/search view so it doesn't want to change the selection.
That's why I thought the best place to change would be in selectMsgByKey.

Comment 6

[[e-mail]]

Fixed by bug 186999.