Closed Bug 1351482 Opened 3 years ago Closed 3 years ago

Upgrade to NSIS 3.01 for buildbot jobs

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox-esr52 fixed, firefox54 fixed, firefox55 fixed)

RESOLVED FIXED
mozilla55
Tracking Status
firefox-esr52 --- fixed
firefox54 --- fixed
firefox55 --- fixed

People

(Reporter: mhowell, Assigned: mhowell)

References

Details

Attachments

(1 file)

As of bug 1236624 and bug 1347191, we can now use NSIS version 3.01 to build Windows installers, instead of the old 3.0 beta we've been on forever. Taskcluster has been switched over already, but buildbot jobs need to get the directory for the newer version added to the PATH before they can pick it up.

Patch (attempt) incoming.
Comment on attachment 8852218 [details]
Bug 1351482 - Use NSIS 3.01 for buildbot jobs.

https://reviewboard.mozilla.org/r/124456/#review127282

From bug 1236624 it sounds like this is already deployed everywhere we need it in automation, right?

When will a new Mozilla-Build be released that includes nsis-3.01? It would be great to have that available for developers to get that locally before we start using it in automation.
Attachment #8852218 - Flags: review?(mshal) → review+
Thanks!

(In reply to Michael Shal [:mshal] from comment #2)
> From bug 1236624 it sounds like this is already deployed everywhere we need
> it in automation, right?
That's correct.

> When will a new Mozilla-Build be released that includes nsis-3.01? It would
> be great to have that available for developers to get that locally before we
> start using it in automation.
That's a question for RyanVM; I know he's working on a new release to get this and several other things updated. I have no problem holding off landing this until that's ready.
Ping for above comment.
Flags: needinfo?(mshal)
Blocks: 1236624
:RyanVM, how far off is a Mozilla-Build release with nsis-3.01? Do you foresee any problems if we land this now but don't have a newer Mozilla-Build for a while?
Flags: needinfo?(mshal) → needinfo?(ryanvm)
I've got a test build created already that includes 3.01, but no ETA on a final release. We will still fallback to 3.0b3, however, so I don't see any issue with updating things in CI.
Flags: needinfo?(ryanvm)
Sounds good - feel free to land away!
Will do; thanks!
Pushed by mhowell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7b2f91e08ae8
Use NSIS 3.01 for buildbot jobs. r=mshal
https://hg.mozilla.org/mozilla-central/rev/7b2f91e08ae8
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Comment on attachment 8852218 [details]
Bug 1351482 - Use NSIS 3.01 for buildbot jobs.

Approval Request Comment
[Feature/Bug causing the regression]: n/a
[User impact if declined]: bug 1215648
[Is this code covered by automated tests?]: yes
[Has the fix been verified in Nightly?]: yes
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: bug 1347191
[Is the change risky?]: no
[Why is the change risky/not risky?]: we've been shipping with alpha/beta level NSIS 3.0 installers for a long time now, this just updates us to a final stable release
[String changes made/needed]: none
Attachment #8852218 - Flags: approval-mozilla-esr52?
Attachment #8852218 - Flags: approval-mozilla-aurora?
Comment on attachment 8852218 [details]
Bug 1351482 - Use NSIS 3.01 for buildbot jobs.

Add support for NSIS 3.01. Aurora54+.
Attachment #8852218 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment on attachment 8852218 [details]
Bug 1351482 - Use NSIS 3.01 for buildbot jobs.

This fix updates the win32 installer/uninstaller system. ESR52.2+
Attachment #8852218 - Flags: approval-mozilla-esr52? → approval-mozilla-esr52+
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.