1351497 - rust.MP4MetadataEmpty fails on opt builds with rust 1.18 nightly

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Ralph Giles (:rillian)]

Testing rustc 1.17.0-nightly (ccce2c6eb 2017-03-27) I see gtest failures on opt builds:

14:33:08     INFO -  TEST-START | rust.MP4MetadataEmpty
14:33:08  WARNING -  TEST-UNEXPECTED-FAIL | rust.MP4MetadataEmpty |       Expected: context
14:33:08     INFO -        Which is: 00971C90
14:33:08     INFO -  To be equal to: nullptr
14:33:08     INFO -        Which is: 4-byte object <00-00 00-00> @ c:/builds/moz2_slave/try-w32-0000000000000000000000/build/src/media/libstagefright/gtest/TestMP4Rust.cpp:78

This is creating an mp4_parser context with a null `read` method. https://dxr.mozilla.org/mozilla-central/source/media/libstagefright/gtest/TestMP4Rust.cpp#76

NB the version says 1.17 but I believe this code will become 1.18 in release. 1.17.0-beta.2 is already available and doesn't show the issue.

Comment 1

[Ralph Giles (:rillian)]

Attachment: release.patch

Can also reproduce with the C++ self-test by building in release mode. Use this attached patch after `cargo +nightly build --release`.

I'm not sure we can demonstrate this with a `cargo test` because I ]think that doesn't test release code. Anyway, I'll try to prepare a reduction.

Comment 2

[Ralph Giles (:rillian)]

I've applied the patch and written a reduced testcast at https://github.com/rillian/mp4parse-rust/tree/nullcheck if anyone else wants to look at it. Reported upstream as rust-lang/rust#40913.

Comment 3

[Matthew Gregan [:kinetik]]

Fix here: https://github.com/mozilla/mp4parse-rust/pull/81

A bug in rusty-cheddar forced us to do the wrong thing.  That bug still exists, so this fix causes the generated mp4parse.h to have a bogusly typed mp4parse_io.read field.  Not sure what to do about that in the short term.

Comment 4

[Matthew Gregan [:kinetik]]

Fix landing via bug 1329126.