1351528 - Streamline TracingMetadata

Status: RESOLVED FIXED

(Core :: Gecko Profiler, enhancement)

Description

[Nicholas Nethercote [inactive]]

I have a couple of clean-ups for TracingMetadata.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: (part 1) - Streamline TracingMetadata

This patch:

- Removes TRACING_EVENT_BACKTRACE, which is unused.

- Removes TRACING_DEFAULT and replaces all its uses with TRACING_EVENT, because
  there is no difference in how those two are used.

- Removes TRACING_TIMESTAMP, which is unused and also doesn't do anything
  different to TRACING_EVENT.

Comment 2

[Nicholas Nethercote [inactive]]

Attachment: (part 2) - Rename TracingMetadata as TracingKind

"Metadata" regularly confuses me, because it suggests something complicated
rather than a simple enum.

This change also has the benefit of removing inconsistent capitalization
("Metadata" vs. "MetaData").

Comment 3

[Markus Stange [:mstange]]

Comment on attachment 8852299 [details] [diff] [review]
(part 2) - Rename TracingMetadata as TracingKind

Review of attachment 8852299 [details] [diff] [review]:
-----------------------------------------------------------------

(In reply to Nicholas Nethercote [:njn] from comment #2)
> This change also has the benefit of removing inconsistent capitalization
> ("Metadata" vs. "MetaData").

Oh dear...

Comment 4

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a04997cb00e9b907c3fc85c8ec1037cf5db611bd
Bug 1351528 (part 1) - Streamline TracingMetadata. r=mstange.

https://hg.mozilla.org/integration/mozilla-inbound/rev/198705c67281eb64995acc8329079f5dfaa09ad4
Bug 1351528 (part 2) - Rename TracingMetadata as TracingKind. r=mstange.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a04997cb00e9
https://hg.mozilla.org/mozilla-central/rev/198705c67281