1351604 - Avoid shipping X509.jsm and DER.jsm until they are used

Status: RESOLVED FIXED

(Core :: Security: PSM, enhancement, P1)

Description

[Florian Quèze [:florian]]

These 2 files seem like they are both pieces of the work for the larger project in bug 1294897. They are currently only referenced by test files, and we shouldn't be shipping them to users until they are actually used.

I assume you want to keep running the tests on them to ensure they don't randomly break, so you will probably want to package them using TESTING_JS_MODULES instead of EXTRA_JS_MODULES for now.

Comment 1

[Dana Keeler (she/her) (use needinfo) [:keeler]]

Whoops - good call.

Comment 2

[Dana Keeler (she/her) (use needinfo) [:keeler]]

Attachment: bug 1351604 - don't ship DER.jsm and X509.jsm until they're actually used in production

Review commit: https://reviewboard.mozilla.org/r/125188/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/125188/

Comment 3

[Dana Keeler (she/her) (use needinfo) [:keeler]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=bf5b3fd95c96aa5b57288d33a9837f0135e8fe81

Comment 4

[Florian Quèze [:florian]]

Thanks for fixing this! You also need to remove the exception at http://searchfox.org/mozilla-central/rev/72fe012899a1b27d34838ab463ad1ae5b116d76b/browser/base/content/test/static/browser_all_files_referenced.js#260 or you'll get a test failure.

Comment 5

[Dana Keeler (she/her) (use needinfo) [:keeler]]

Comment on attachment 8853117 [details]
bug 1351604 - don't ship DER.jsm and X509.jsm until they're actually used in production

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/125188/diff/1-2/

Comment 6

[Dana Keeler (she/her) (use needinfo) [:keeler]]

Ah, thanks for the pointer.

Comment 7

[:Cykesiopka]

Comment on attachment 8853117 [details]
bug 1351604 - don't ship DER.jsm and X509.jsm until they're actually used in production

https://reviewboard.mozilla.org/r/125188/#review128104

Looks good.

Comment 8

[Dana Keeler (she/her) (use needinfo) [:keeler]]

Thanks!

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e46f832ac262
don't ship DER.jsm and X509.jsm until they're actually used in production r=Cykesiopka

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Backed out in https://hg.mozilla.org/integration/autoland/rev/c98326636d91 for failures like https://treeherder.mozilla.org/logviewer.html#?job_id=87932930&repo=autoland

Comment 11

[Dana Keeler (she/her) (use needinfo) [:keeler]]

The patch is fine: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f14554c29da2&selectedJob=87967137
I think it just needs a clobber.

Comment 12

[Dana Keeler (she/her) (use needinfo) [:keeler]]

Comment on attachment 8853117 [details]
bug 1351604 - don't ship DER.jsm and X509.jsm until they're actually used in production

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/125188/diff/2-3/

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e87ffc90adf0
don't ship DER.jsm and X509.jsm until they're actually used in production r=Cykesiopka

Comment 14

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/e87ffc90adf0