Closed Bug 1351604 Opened 3 years ago Closed 3 years ago

Avoid shipping X509.jsm and DER.jsm until they are used

Categories

(Core :: Security: PSM, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: florian, Assigned: keeler)

References

(Blocks 1 open bug)

Details

(Whiteboard: [psm-assigned])

Attachments

(1 file)

These 2 files seem like they are both pieces of the work for the larger project in bug 1294897. They are currently only referenced by test files, and we shouldn't be shipping them to users until they are actually used.

I assume you want to keep running the tests on them to ensure they don't randomly break, so you will probably want to package them using TESTING_JS_MODULES instead of EXTRA_JS_MODULES for now.
Whoops - good call.
Assignee: nobody → dkeeler
Priority: -- → P1
Whiteboard: [psm-assigned]
Ah, thanks for the pointer.
Comment on attachment 8853117 [details]
bug 1351604 - don't ship DER.jsm and X509.jsm until they're actually used in production

https://reviewboard.mozilla.org/r/125188/#review128104

Looks good.
Attachment #8853117 - Flags: review?(cykesiopka.bmo) → review+
Pushed by dkeeler@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e46f832ac262
don't ship DER.jsm and X509.jsm until they're actually used in production r=Cykesiopka
Pushed by dkeeler@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e87ffc90adf0
don't ship DER.jsm and X509.jsm until they're actually used in production r=Cykesiopka
https://hg.mozilla.org/mozilla-central/rev/e87ffc90adf0
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Depends on: 1352982
You need to log in before you can comment on or make changes to this bug.