Closed Bug 1351604 Opened 3 years ago Closed 3 years ago
Avoid shipping X509
.jsm and DER .jsm until they are used
59 bytes, text/x-review-board-request
These 2 files seem like they are both pieces of the work for the larger project in bug 1294897. They are currently only referenced by test files, and we shouldn't be shipping them to users until they are actually used. I assume you want to keep running the tests on them to ensure they don't randomly break, so you will probably want to package them using TESTING_JS_MODULES instead of EXTRA_JS_MODULES for now.
Whoops - good call.
Assignee: nobody → dkeeler
Priority: -- → P1
Thanks for fixing this! You also need to remove the exception at http://searchfox.org/mozilla-central/rev/72fe012899a1b27d34838ab463ad1ae5b116d76b/browser/base/content/test/static/browser_all_files_referenced.js#260 or you'll get a test failure.
Ah, thanks for the pointer.
Comment on attachment 8853117 [details] bug 1351604 - don't ship DER.jsm and X509.jsm until they're actually used in production https://reviewboard.mozilla.org/r/125188/#review128104 Looks good.
Attachment #8853117 - Flags: review?(cykesiopka.bmo) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/e46f832ac262 don't ship DER.jsm and X509.jsm until they're actually used in production r=Cykesiopka
Backed out in https://hg.mozilla.org/integration/autoland/rev/c98326636d91 for failures like https://treeherder.mozilla.org/logviewer.html#?job_id=87932930&repo=autoland
The patch is fine: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f14554c29da2&selectedJob=87967137 I think it just needs a clobber.
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/e87ffc90adf0 don't ship DER.jsm and X509.jsm until they're actually used in production r=Cykesiopka
You need to log in before you can comment on or make changes to this bug.