Avoid shipping X509.jsm and DER.jsm until they are used

RESOLVED FIXED in Firefox 55

Status

()

Core
Security: PSM
P1
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: florian, Assigned: keeler)

Tracking

(Blocks: 1 bug)

unspecified
mozilla55
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox55 fixed)

Details

(Whiteboard: [psm-assigned])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

These 2 files seem like they are both pieces of the work for the larger project in bug 1294897. They are currently only referenced by test files, and we shouldn't be shipping them to users until they are actually used.

I assume you want to keep running the tests on them to ensure they don't randomly break, so you will probably want to package them using TESTING_JS_MODULES instead of EXTRA_JS_MODULES for now.
(Assignee)

Comment 1

a year ago
Whoops - good call.
Assignee: nobody → dkeeler
Priority: -- → P1
Whiteboard: [psm-assigned]
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Comment 6

a year ago
Ah, thanks for the pointer.

Comment 7

a year ago
mozreview-review
Comment on attachment 8853117 [details]
bug 1351604 - don't ship DER.jsm and X509.jsm until they're actually used in production

https://reviewboard.mozilla.org/r/125188/#review128104

Looks good.
Attachment #8853117 - Flags: review?(cykesiopka.bmo) → review+
(Assignee)

Comment 8

a year ago
Thanks!

Comment 9

a year ago
Pushed by dkeeler@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e46f832ac262
don't ship DER.jsm and X509.jsm until they're actually used in production r=Cykesiopka
(Assignee)

Comment 11

a year ago
The patch is fine: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f14554c29da2&selectedJob=87967137
I think it just needs a clobber.
Flags: needinfo?(dkeeler)
Comment hidden (mozreview-request)

Comment 13

a year ago
Pushed by dkeeler@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e87ffc90adf0
don't ship DER.jsm and X509.jsm until they're actually used in production r=Cykesiopka
https://hg.mozilla.org/mozilla-central/rev/e87ffc90adf0
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.