1351607 - Split spidermonkey test prefix into multiple -e arguments to be compatible with lldb

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement)

Description

[Lars T Hansen [:lth]]

This is just silly but it bugs me to no end because I develop on Mac:

The command prefix that our test infra uses with the spidermonkey shell defines a bunch of top-level variables, like so:

-e "const platform='darwin'; const libdir='/Users/lhansen/moz/mozilla-inbound/js/src/jit-test/lib/'; const scriptdir='/Users/lhansen/moz/mozilla-inbound/js/src/jit-test/tests/wasm/'"

Tragically the semicolons are incompatible with lldb's command line parser, so if I take the output of eg jit_test.py -f and just paste it in as a 'run' command in lldb it won't work.  I have to edit the line to remove the semicolons and split the assignments into multiple -e arguments.

(It's possible a comma would also work, I haven't tested yet.  Maybe inverting the quotes would help (double inside single), I don't know.  lldb docs says that I should perhaps be able to start it with "process start" or somesuch but no luck there either.)

Anyway the infra should change so that this extra work is not necessary.

Comment 1

[Lars T Hansen [:lth]]

Attachment: bug1351607-split-expression-args.patch

Split the expressions that the test runner passes to the spidermonkey shell into separate '-e' command line arguments to avoid incompatibility with lldb's command parser (it can't deal with the semicolons).

Comment 2

[Luke Wagner [:luke]]

Oh *that's* why it never worked...

Comment 3

[Steve Fink [:sfink] [:s:]]

Comment on attachment 8852421 [details] [diff] [review]
bug1351607-split-expression-args.patch

Review of attachment 8852421 [details] [diff] [review]:
-----------------------------------------------------------------

WFM

Comment 4

[Lars T Hansen [:lth]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8687e282be2e481d626883ef9adab2c41143a24b
Bug 1351607 - pass -e expressions to the JS shell as separate command line arguments. r=sfink

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8687e282be2e
pass -e expressions to the JS shell as separate command line arguments. r=sfink

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8687e282be2e