Closed Bug 1351607 Opened 5 years ago Closed 5 years ago

Split spidermonkey test prefix into multiple -e arguments to be compatible with lldb

Categories

(Core :: JavaScript Engine, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: lth, Assigned: lth)

Details

Attachments

(1 file)

This is just silly but it bugs me to no end because I develop on Mac:

The command prefix that our test infra uses with the spidermonkey shell defines a bunch of top-level variables, like so:

-e "const platform='darwin'; const libdir='/Users/lhansen/moz/mozilla-inbound/js/src/jit-test/lib/'; const scriptdir='/Users/lhansen/moz/mozilla-inbound/js/src/jit-test/tests/wasm/'"

Tragically the semicolons are incompatible with lldb's command line parser, so if I take the output of eg jit_test.py -f and just paste it in as a 'run' command in lldb it won't work.  I have to edit the line to remove the semicolons and split the assignments into multiple -e arguments.

(It's possible a comma would also work, I haven't tested yet.  Maybe inverting the quotes would help (double inside single), I don't know.  lldb docs says that I should perhaps be able to start it with "process start" or somesuch but no luck there either.)

Anyway the infra should change so that this extra work is not necessary.
Split the expressions that the test runner passes to the spidermonkey shell into separate '-e' command line arguments to avoid incompatibility with lldb's command parser (it can't deal with the semicolons).
Assignee: nobody → lhansen
Status: NEW → ASSIGNED
Attachment #8852421 - Flags: review?(sphink)
Oh *that's* why it never worked...
Comment on attachment 8852421 [details] [diff] [review]
bug1351607-split-expression-args.patch

Review of attachment 8852421 [details] [diff] [review]:
-----------------------------------------------------------------

WFM
Attachment #8852421 - Flags: review?(sphink) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/8687e282be2e481d626883ef9adab2c41143a24b
Bug 1351607 - pass -e expressions to the JS shell as separate command line arguments. r=sfink
Pushed by lhansen@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8687e282be2e
pass -e expressions to the JS shell as separate command line arguments. r=sfink
https://hg.mozilla.org/mozilla-central/rev/8687e282be2e
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.