1351651 - [Regression] Firefox will crash when requesting desktop site from the Share menu

Status: VERIFIED FIXED

(Firefox for iOS :: General, defect)

Description

[Simon Basca [:SimonB]]

Build: 7.0b2286
Device: iPad mini 4
iOS: 10.3

Steps to reproduce:
1. Go to youtube.com
2. Tap on the Share menu
3. Tap 'Request Desktop Site'

Actual results:
- Firefox will crash.

Note:
- Issue not reproducible on latest master a18df199a08
- I can't find a crash log on beta

See video:
- https://www.youtube.com/watch?v=f9YIh7s9H9Y

Comment 1

[Aaron Train [:aaronmt]]

Reproducible on Reddit on my iPad

Comment 2

[Justin D'Arcangelo [:justindarc]]

(In reply to Aaron Train [:aaronmt] from comment #1)
> Reproducible on Reddit on my iPad

What iOS version are you on?

Comment 3

[Catalin Suciu [:csuciu]]

Justin, we were able to reproduce the crash on 10.2 and 10.3. Didn't tested on 9.x.

Comment 4

[Aaron Train [:aaronmt]]

10.3 for me

Comment 5

[Catalin Suciu [:csuciu]]

Here's a list of devices on which we are able to reproduce the crash just by going to any site (e.g Facebook) and RDS from Share menu:

* iPad Air 2 - iOS 10.2
* iPhone 6 Plus - iOS 10.2.1  
* iPhone 6 Plus - iOS 9.3.4
* iPad mini 4 - iOS 10.3
* iPhone 6S - iOS 10.3  
* iPhone 7 Plus - iOS 10.1.1

Comment 6

[Catalin Suciu [:csuciu]]

Tapping on 'Find in page' in Share menu is also crashing Beta. Unfortunately, I'm not getting any crash logs for this issue in Beta and I can't reproduce it on master. 

Justin, can you please take a look and see if those two issues have the same root cause?

Comment 7

[Justin D'Arcangelo [:justindarc]]

Attachment: Crash Log

Comment 8

[Justin D'Arcangelo [:justindarc]]

Attachment: GitHub Pull Request

Swift optimizer FAIL.

Comment 9

[Justin D'Arcangelo [:justindarc]]

Landed on v7.x:

https://github.com/mozilla-mobile/firefox-ios/commit/224a94177a61dca2b7c1f6f09a07474ae712119b

Comment 10

[Justin D'Arcangelo [:justindarc]]

Follow-up to remove this de-optimization in the future: Bug 1352220

Comment 11

[Justin D'Arcangelo [:justindarc]]

Landed on master:

https://github.com/mozilla-mobile/firefox-ios/commit/067b6670e8216e7822f94dd3881f25ff481d31b8

Comment 12

[Simon Basca [:SimonB]]

Verifying as fix on 7.0b2330. The crash is no longer reproducible when requesting desktop site or taping find in page from the Share menu.