1351745 - Disable -moz-appearance for non-UA/chrome sheets

Status: REOPENED

(Core :: CSS Parsing and Computation, enhancement, P3)

Description

[Mats Palmgren (inactive)]

Follow-up from bug 1333482.

Comment 1

[Sebastian Zartner [:sebo]]

Once fixed, this should be documented at https://developer.mozilla.org/en-US/docs/Web/CSS/-moz-appearance.

Sebastian

Comment 2

[ExE Boss]

Given that bug 1333482 is not web compatible at all and `‑webkit‑appearance` has since been implemented as an alias for `‑moz‑appearance` in bug 1368555 and bug 1429713, this seems like a very clear WONTFIX to me.

Comment 3

[Kagami Rosylight [:saschanaz] (they/them)]

Having this causes at least one webcompat issue. I think having webkit prefixed one as an alias of moz prefixed one still allows us to have only the former, right?

Comment 4

[Emilio Cobos Álvarez [:emilio]]

(In reply to Kagami Rosylight [:saschanaz] (they/them) from comment #3)

Having this causes at least one webcompat issue. I think having webkit prefixed one as an alias of moz prefixed one still allows us to have only the former, right?

Well, kind of? As you noted, MozAppearance is used for UA sniffing, so the question is whether removing it would cause issues than it fixes.

Comment 5

[Emilio Cobos Álvarez [:emilio]]

We also need to account for pages using things like -moz-appearance: textfield to suppress number input spinners and so on... I did some github searching, and most "MozAppearance" in ... bits seem harmless, but pages would regress due to -moz-appearance: textfield. So maybe we need to remove it from the OM but keep parsing -moz-appearance?

Comment 6

[Kagami Rosylight [:saschanaz] (they/them)]

By tweaking GenerateCSSPropListWebIDL.py? Works for me.