135189 - M099 crashes [@ morkTable::AddRow]

Status: RESOLVED WORKSFORME

(MailNews Core :: Database, defect)

Description

[greer]

There are 54 users crashes in M099 reported in Talkback in the past 10 days at
morkTable::AddRow. Trunk reports show only one incident on the 2002032610 Trunk
build, but that isn't too shocking since most users don't use Trunk builds for mail.

Based on checkin dates, it doesn't look like a mork issue or a problem in
nsMsgThread. But I'm sending this to Mail DB based on the crash signature. 

David or Seth, can you set me straight on where this should go, or better yet if
there is a bug I'm missing that has already fixed this on the Trunk. Thanks.

Here's a sample stack (followed by all comments):

(Incident #4655298 M099)
Comments: deleting a lot of messages(mail)l from an IMAP server  then clicked
onto another folder before finished.

morkTable::AddRow [d:\builds\seamonkey\mozilla\db\mork\src\morkTable.cpp, line 664] 
nsMsgThread::AddChild
[d:\builds\seamonkey\mozilla\mailnews\db\msgdb\src\nsMsgThread.cpp, line 272] 
nsMsgDatabase::AddToThread
[d:\builds\seamonkey\mozilla\mailnews\db\msgdb\src\nsMsgDatabase.cpp, line 3394] 
nsMsgDatabase::AddNewThread
[d:\builds\seamonkey\mozilla\mailnews\db\msgdb\src\nsMsgDatabase.cpp, line 3569] 
nsMsgDatabase::ThreadNewHdr
[d:\builds\seamonkey\mozilla\mailnews\db\msgdb\src\nsMsgDatabase.cpp, line 3379] 
nsMsgDatabase::AddNewHdrToDB
[d:\builds\seamonkey\mozilla\mailnews\db\msgdb\src\nsMsgDatabase.cpp, line 2666] 
nsImapMailFolder::NormalEndHeaderParseStream
[d:\builds\seamonkey\mozilla\mailnews\imap\src\nsImapMailFolder.cpp, line 2579] 
XPTC_InvokeByIndex
[d:\builds\seamonkey\mozilla\xpcom\reflect\xptcall\src\md\win32\xptcinvoke.cpp,
line 106] 
EventHandler [d:\builds\seamonkey\mozilla\xpcom\proxy\src\nsProxyEvent.cpp, line
516] 
PL_HandleEvent [d:\builds\seamonkey\mozilla\xpcom\threads\plevent.c, line 591] 
PL_ProcessPendingEvents [d:\builds\seamonkey\mozilla\xpcom\threads\plevent.c,
line 524] 
_md_EventReceiverProc [d:\builds\seamonkey\mozilla\xpcom\threads\plevent.c, line
1072] 
nsAppShellService::Run
[d:\builds\seamonkey\mozilla\xpfe\appshell\src\nsAppShellService.cpp, line 309] 
main1 [d:\builds\seamonkey\mozilla\xpfe\bootstrap\nsAppRunner.cpp, line 1305] 
main [d:\builds\seamonkey\mozilla\xpfe\bootstrap\nsAppRunner.cpp, line 1640] 
WinMain [d:\builds\seamonkey\mozilla\xpfe\bootstrap\nsAppRunner.cpp, line 1658] 
WinMainCRTStartup() 
KERNEL32.DLL + 0x192a6 (0x77e992a6) 


M099 (morkTable::AddRow):       54
(4459740) - [Windows NT  5.0 build 2195]: simply going to view another mail
directory (in local folder  while in an imap server directory). Happens from
time to time now  seems an unknown event has changed something. May be i should
take a look at my pluggins. 
(4583570) - [Windows NT  5.0 build 2195]: clicking on email folders 
(4586222) - [Windows 98  4.10 build 67766446]: deleting a substantial number of
messages in one go. 
(4619539) - [Windows NT  5.1 build 2600]: Accessing a mailbox (opening it) and
attempting to start a search on it at the same time!  
(4635555) - [Windows NT  5.0 build 2195]: Moving unwanted mailbox files to
Trash.  I tried to shift-click to see if I could select several at once and then
the crash happened. 
(4655298) - [Windows NT  5.0 build 2195]: deleting a lot of messages(mail)l from
an IMAP server  then clicked onto another folder before finished. URL: 
(4707403) - [Windows NT  5.0 build 2195]: While Mailnews was building an index
for some big local mail folder  I clicked on a different folder. Mozilla crashed
immediately. 
(4722744) - [Windows NT  5.0 build 2195]: Selecting inbox. Communicator was
unresponsive in getting mail for some time. 
(4723505) - [Windows NT  5.0 build 2195]: quickly clicking on mail folders 
(4729065) - [Windows NT  5.0 build 2195]: received new emails in messenger  did
not find the new message anywhere and was browsing folders  suddenly mozilla had
this error 
(4731733) - [Windows NT  5.0 build 2195]: last time i used mozilla messenger.
switching to The Bat! ;-( 
(4491560) - [Linux 2.4.7-10]: reading mail 
(4504284) - [Linux 2.4.18-6mdk]: I were using the mail program and I copied a
folder from an IMAP account into my  "Local folders" when the error occured. 
(4746758) - [Linux 2.4.18]: While opening a big folder at the Mail client I
change my mind and select another one. The foldar was still being loaded and the
application crashed completely.
 
Trunk (morkTable::AddRow):        1
(4652542) - [Linux 2.4.18]: Crashed in email yet again. Time to get newer build.

Comment 1

[David :Bienvenu]

I think this is going to be WFM on the trunk - there are several of these mork
crashers in .9.9 but not on the trunk. I believe there are some changes on the
trunk that prevents this crash

Comment 2

[greer]

Because this one is a topcrash on M099 I'm including the topcrash- keyword for
our tracking. But I agree with David, this one looks like WFM. There continue to
be no incidents on the Trunk.

Comment 3

[David :Bienvenu]

wfm on trunk.

Comment 4

[laurel]

marking verified worksforme based on latest comments.

Comment 5

[monperrus]

For one month now, TB crashes several times per day no morkTable::AddRow(nsIMdbEnv*, nsIMdbRow*) .

See one instance on Thunderbird 41.0b2:
https://crash-stats.mozilla.com/report/index/41840bed-8818-4d60-bf18-af5fb2150921

Should I open a new issue?

Comment 6

[Kent James (:rkent)]

This appears to be a rare crash, so I suspect that you have some local database corruption that is contributing to your crashes. But we can reopen.

Looking at the code, this is probably a null hdr row. In most cases code protects against null rows, in this case it does not appear to do so.

Comment 7

[Wayne Mery (:wsmwk)]

(In reply to martin.monperrus from comment #5)
> For one month now, TB crashes several times per day no
> morkTable::AddRow(nsIMdbEnv*, nsIMdbRow*) .
> 
> See one instance on Thunderbird 41.0b2:
> https://crash-stats.mozilla.com/report/index/41840bed-8818-4d60-bf18-
> af5fb2150921
> 
> Should I open a new issue?

If you do not find a solution, yes please. Because we should consider the original issue to be dead and gone.

Note - you are the ONLY person with that crash signature

Comment 8

[monperrus]

What I can do is to repair the folders as a workaround. If it solves the crashes that's good for me, but it's not a definitive solution for the future occurrences of this rare crash.

Comment 9

[monperrus]

Created a new bug 1218357 for this