Closed Bug 1351933 Opened 6 years ago Closed 6 years ago

[e10s] Remove support for whitelisting addons for the e10s rollout

Categories

(Firefox :: General, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 55
Tracking Status
firefox55 --- fixed

People

(Reporter: Felipe, Assigned: Felipe)

Details

Attachments

(1 file)

Since we will no longer be using a whitelist for addons (because that would allow addons that are not mpc=true to use shims), we can remove all the whitelist support which will be some good code cleanup.
Attachment #8852745 - Flags: review?(gkrizsanits)
Gabor, I wrote this patch to take some no longer needed code out of your way for the e10s-multi rollout. Hopefully that will things a little bit simpler.
Comment on attachment 8852745 [details]
Bug 1351933 - Remove support for whitelisting addons for the e10s rollout.

https://reviewboard.mozilla.org/r/124906/#review128092

Sorry for the lag, it looks all good, and thanks for the cleanup :)
Attachment #8852745 - Flags: review?(gkrizsanits) → review+
Pushed by felipc@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/06ab61f0402e
Remove support for whitelisting addons for the e10s rollout. r=krizsa
Backed out for eslint failures in test_e10s_restartless.js:

https://hg.mozilla.org/integration/autoland/rev/43e912c0d90fb28b2e93c9395c63c481762305ca

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=06ab61f0402e3e2c807ff829eb48e645dd034f44&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=87918370&repo=autoland

TEST-UNEXPECTED-ERROR | /home/worker/checkouts/gecko/toolkit/mozapps/extensions/test/xpcshell/test_e10s_restartless.js:433:3 | 'addon3' is not defined. (no-undef)
TEST-UNEXPECTED-ERROR | /home/worker/checkouts/gecko/toolkit/mozapps/extensions/test/xpcshell/test_e10s_restartless.js:435:15 | 'addon3' is not defined. (no-undef)
Flags: needinfo?(felipc)
Missed a `let`
Flags: needinfo?(felipc)
I added the let in the updated patch I just posted. The interdiff shows more stuff because bug 1346288 added to the same test file that I'm adding. Due to that I'm sending this to tryserver first before pushing again.
Pushed by felipc@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/29749bbfaa48
Remove support for whitelisting addons for the e10s rollout. r=krizsa
https://hg.mozilla.org/mozilla-central/rev/29749bbfaa48
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
You need to log in before you can comment on or make changes to this bug.