1351946 - Remove SigstartHandler

Status: RESOLVED FIXED

(Core :: Gecko Profiler, enhancement)

Description

[Markus Stange [:mstange]]

This is the signal handler I originally had in mind when I filed bug 1328916.

On B2G, the profiler was started using a signal, from this script: https://github.com/mozilla-b2g/B2G/blob/master/profile.sh#L223

Before sending the signal, this script would write profiler start options to a file called /data/local/tmp/profiler.options . The signal handler reads that file and starts the profiler.

We don't need this infrastructure any more.

Comment 1

[Nicholas Nethercote [inactive]]

I can do this! I will happily remove this code. It's been annoying me :)

Comment 2

[Nicholas Nethercote [inactive]]

Attachment: (part 1) - Remove SigstartHandler from the profiler

It was only needed for B2G.

Comment 3

[Nicholas Nethercote [inactive]]

Attachment: (part 2) - Inline and remove GetEntries() and GetInterval()

Comment 4

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/19699bdcdde24c24e60e0022ecf49e6731e9d90b
Bug 1351946 (part 1) - Remove SigstartHandler from the profiler. r=mstange.

https://hg.mozilla.org/integration/mozilla-inbound/rev/ea478f5716027ddf1f06134beea5a0ffa3fb49cc
Bug 1351946 (part 2) - Inline and remove GetEntries() and GetInterval(). r=mstange.

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/19699bdcdde2
https://hg.mozilla.org/mozilla-central/rev/ea478f571602