Remove SigstartHandler

RESOLVED FIXED in Firefox 55

Status

()

Core
Gecko Profiler
RESOLVED FIXED
3 months ago
3 months ago

People

(Reporter: mstange, Assigned: njn)

Tracking

Trunk
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(2 attachments)

(Reporter)

Description

3 months ago
This is the signal handler I originally had in mind when I filed bug 1328916.

On B2G, the profiler was started using a signal, from this script: https://github.com/mozilla-b2g/B2G/blob/master/profile.sh#L223

Before sending the signal, this script would write profiler start options to a file called /data/local/tmp/profiler.options . The signal handler reads that file and starts the profiler.

We don't need this infrastructure any more.
(Assignee)

Comment 1

3 months ago
I can do this! I will happily remove this code. It's been annoying me :)
(Assignee)

Comment 2

3 months ago
Created attachment 8852794 [details] [diff] [review]
(part 1) - Remove SigstartHandler from the profiler

It was only needed for B2G.
Attachment #8852794 - Flags: review?(mstange)
(Assignee)

Updated

3 months ago
Assignee: nobody → n.nethercote
Status: NEW → ASSIGNED
(Assignee)

Comment 3

3 months ago
Created attachment 8852795 [details] [diff] [review]
(part 2) - Inline and remove GetEntries() and GetInterval()
Attachment #8852795 - Flags: review?(mstange)
(Reporter)

Updated

3 months ago
Attachment #8852794 - Flags: review?(mstange) → review+
(Reporter)

Updated

3 months ago
Attachment #8852795 - Flags: review?(mstange) → review+
(Assignee)

Comment 4

3 months ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/19699bdcdde24c24e60e0022ecf49e6731e9d90b
Bug 1351946 (part 1) - Remove SigstartHandler from the profiler. r=mstange.

https://hg.mozilla.org/integration/mozilla-inbound/rev/ea478f5716027ddf1f06134beea5a0ffa3fb49cc
Bug 1351946 (part 2) - Inline and remove GetEntries() and GetInterval(). r=mstange.

Comment 5

3 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/19699bdcdde2
https://hg.mozilla.org/mozilla-central/rev/ea478f571602
Status: ASSIGNED → RESOLVED
Last Resolved: 3 months ago
status-firefox55: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.