Closed Bug 1351953 Opened 3 years ago Closed 3 years ago

Use Shmems to send encrypted video frames and samples through PChromiumCDM

Categories

(Core :: Audio/Video: GMP, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: cpearce, Assigned: cpearce)

References

Details

Attachments

(3 files)

The new PChromiumCDM protocol should be using shmems to send video frames and compressed encrypted samples between the content/GMP process.
Depends on: 1351954
Comment on attachment 8854652 [details]
Bug 1351953 - Make DecryptJob::PostResult take a mozilla::Span instead of nsTArray.

https://reviewboard.mozilla.org/r/126588/#review129354
Attachment #8854652 - Flags: review?(gsquelart) → review+
Comment on attachment 8854651 [details]
Bug 1351953 - Send Data to CDM for decrypt and or decode in shmems.

https://reviewboard.mozilla.org/r/126586/#review129360
Attachment #8854651 - Flags: review?(gsquelart) → review+
Comment on attachment 8854653 [details]
Bug 1351953 - Pre-allocate shmems for the CDM process to use for storing decrypted and audio samples.

https://reviewboard.mozilla.org/r/126590/#review129362

::: commit-message-bed71:21
(Diff revision 2)
> +list of shmems with shmems of at least that size, plus a bit of padding for
> +safety.

"plus a bit of padding for safety" -- that sounds dangerous!
I see in the code you make sizes be multiple of 16, maybe you could just explain that and why.
Attachment #8854653 - Flags: review?(gsquelart) → review+
Pushed by cpearce@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/135680bdc3be
Send Data to CDM for decrypt and or decode in shmems. r=gerald
https://hg.mozilla.org/integration/autoland/rev/b2674e5e09f9
Make DecryptJob::PostResult take a mozilla::Span instead of nsTArray. r=gerald
https://hg.mozilla.org/integration/autoland/rev/d0d1782c7b2f
Pre-allocate shmems for the CDM process to use for storing decrypted and audio samples. r=gerald
You need to log in before you can comment on or make changes to this bug.