1351968 - Pref off full-duplex for Mac in beta 53

Status: RESOLVED FIXED

(Core :: Audio/Video: cubeb, enhancement, P1)

Description

[Randell Jesup [:jesup] (needinfo me)]

We want to pref off full-duplex for mac due to drift problems when aggregate devices aren't used, and aggregate devices is in 54.  We decided to focus on testing aggregate instead of a hacky patch to try to wallpaper 53 for mac.

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

Attachment: pref off full-duplex audio for Mac (beta 53) rs=jesup

MozReview-Commit-ID: fonVvGv8VC

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8852792 [details] [diff] [review]
pref off full-duplex audio for Mac (beta 53) rs=jesup

Approval Request Comment
[Feature/Bug causing the regression]: N/A

[User impact if declined]: some users on mac will have wildly-drifting audio (delayed seconds)

[Is this code covered by automated tests?]: no - requires HW mic

[Has the fix been verified in Nightly?]: N/A

[Needs manual test from QE? If yes, steps to reproduce]: No

[List of other uplifts needed for the feature/fix]: none

[Is the change risky?]: no

[Why is the change risky/not risky?]: we've been using non-full-duplex in release and late beta all along.

[String changes made/needed]: none

Comment 3

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8852792 [details] [diff] [review]
pref off full-duplex audio for Mac (beta 53) rs=jesup

Let's uplift this to beta 53 as discussed at the product meeting. We are only shipping full duplex audio to Windows for 53.

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-beta/rev/d39a2eac4b5c