Closed
Bug 1352004
Opened 4 years ago
Closed 4 years ago
Doorhangers missing background
Categories
(Firefox for Android Graveyard :: Web Apps (PWAs), defect, P1)
Firefox for Android Graveyard
Web Apps (PWAs)
Tracking
(firefox55 verified)
VERIFIED
FIXED
Firefox 55
Tracking | Status | |
---|---|---|
firefox55 | --- | verified |
People
(Reporter: daleharvey, Assigned: cnevinchen)
References
Details
Attachments
(2 files)
Install https://daleharvey.github.io/testapp/, launch and click "Get Geolocation" The doorhanger works but is missing the dark background which is confusing
Updated•4 years ago
|
Component: General → Web Apps
Updated•4 years ago
|
Priority: -- → P1
Comment 1•4 years ago
|
||
Dale, let me know if you are able to take this.
Reporter | ||
Updated•4 years ago
|
Assignee: nobody → dale
Reporter | ||
Updated•4 years ago
|
Assignee: dale → nobody
Assignee | ||
Comment 2•4 years ago
|
||
I guess you should implement the PopupWindow callback like this. Please teach me how to install https://daleharvey.github.io/testapp/ so I can work on this. I try "add to home screen" but it doesn't shows WebAppActivity. http://searchfox.org/mozilla-central/rev/eace920a0372051a11d8d275bd9b8f14f3024ecd/mobile/android/base/java/org/mozilla/gecko/BrowserApp.java#1620
Flags: needinfo?(dale)
Assignee | ||
Comment 3•4 years ago
|
||
Currently I'm using adb shell am start -n "org.mozilla.fennec_nechen/org.mozilla.gecko.App" -a org.mozilla.gecko.WEBAPP -e MANIFEST_PATH "https://daleharvey.github.io/testapp/manifest.json" -d "https://daleharvey.github.io/testapp/" to test
Comment hidden (mozreview-request) |
Comment 5•4 years ago
|
||
> Please teach me how to install https://daleharvey.github.io/testapp/ so I maybe this https://bugzilla.mozilla.org/show_bug.cgi?id=1336355#c19
Comment hidden (mozreview-request) |
Assignee | ||
Updated•4 years ago
|
Assignee: nobody → cnevinchen
Comment 7•4 years ago
|
||
mozreview-review |
Comment on attachment 8856438 [details] Bug 1352004 - Fix doorhangers missing background. https://reviewboard.mozilla.org/r/128392/#review131970 ::: mobile/android/base/java/org/mozilla/gecko/GeckoApp.java:1580 (Diff revision 2) > mFormAssistPopup = (FormAssistPopup) findViewById(R.id.form_assist_popup); > } > > + @Override > + public void onDoorHangerShow() { > + View overlay = getDoorhangerOverlay(); nit: final ::: mobile/android/base/java/org/mozilla/gecko/GeckoApp.java:1591 (Diff revision 2) > + } > + } > + > + @Override > + public void onDoorHangerHide() { > + View overlay = getDoorhangerOverlay(); .. and here.
Attachment #8856438 -
Flags: review?(s.kaspari) → review+
Comment hidden (mozreview-request) |
Comment 9•4 years ago
|
||
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again. hg error in cmd: hg rebase -s edb131599f6f -d 5ef0eb3d0b26: rebasing 390213:edb131599f6f "Bug 1352004 - Fix doorhangers missing background. r=sebastian" (tip) merging mobile/android/base/java/org/mozilla/gecko/customtabs/CustomTabsActivity.java merging mobile/android/base/java/org/mozilla/gecko/webapps/WebAppActivity.java warning: conflicts while merging mobile/android/base/java/org/mozilla/gecko/webapps/WebAppActivity.java! (edit, then use 'hg resolve --mark') unresolved conflicts (see hg resolve, then hg rebase --continue)
Comment hidden (mozreview-request) |
Comment 11•4 years ago
|
||
Pushed by nechen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3148ecea537e Fix doorhangers missing background. r=sebastian
![]() |
||
Comment 12•4 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/3148ecea537e
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Reporter | ||
Comment 13•4 years ago
|
||
> Currently I'm using .... to test
Thats a super nice trick, I may copy you. I have just been setting manifest.install.enabled=true in prefs and then adding it to the homescreen for reference.
Flags: needinfo?(dale)
Comment 14•4 years ago
|
||
Verified as fixed on Nightly 55.0a1 (2017-04-20). Devices: -LG G4 (Android 5.1) -Motorola Nexus 6 (Android 7.0) -Asus ZenPad 8.0 Z380KL (Android 6.0.1)
Status: RESOLVED → VERIFIED
Updated•1 month ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•