1352004 - Doorhangers missing background

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Web Apps (PWAs), defect, P1)

Description

[Dale Harvey (:daleharvey)]

Attachment: Screenshot_20170330-101615.png

Install https://daleharvey.github.io/testapp/, launch and click "Get Geolocation"

The doorhanger works but is missing the dark background which is confusing

Comment 1

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

Dale, 
let me know if you are able to take this.

Comment 2

[Nevin Chen(Not active on Bugzilla)]

I guess you should implement the PopupWindow callback like this.
Please teach me how to install https://daleharvey.github.io/testapp/ so I can work on this.
I try "add to home screen" but it doesn't shows WebAppActivity.

http://searchfox.org/mozilla-central/rev/eace920a0372051a11d8d275bd9b8f14f3024ecd/mobile/android/base/java/org/mozilla/gecko/BrowserApp.java#1620

Comment 3

[Nevin Chen(Not active on Bugzilla)]

Currently I'm using 
adb shell am start -n "org.mozilla.fennec_nechen/org.mozilla.gecko.App" -a org.mozilla.gecko.WEBAPP  -e MANIFEST_PATH "https://daleharvey.github.io/testapp/manifest.json" -d "https://daleharvey.github.io/testapp/"
to test

Comment 4

[Nevin Chen(Not active on Bugzilla)]

Attachment: Bug 1352004 - Fix doorhangers missing background.

Review commit: https://reviewboard.mozilla.org/r/128392/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/128392/

Comment 5

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

> Please teach me how to install https://daleharvey.github.io/testapp/ so I

maybe this https://bugzilla.mozilla.org/show_bug.cgi?id=1336355#c19

Comment 6

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8856438 [details]
Bug 1352004 - Fix doorhangers missing background.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/128392/diff/1-2/

Comment 7

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8856438 [details]
Bug 1352004 - Fix doorhangers missing background.

https://reviewboard.mozilla.org/r/128392/#review131970

::: mobile/android/base/java/org/mozilla/gecko/GeckoApp.java:1580
(Diff revision 2)
>          mFormAssistPopup = (FormAssistPopup) findViewById(R.id.form_assist_popup);
>      }
>  
> +    @Override
> +    public void onDoorHangerShow() {
> +        View overlay = getDoorhangerOverlay();

nit: final

::: mobile/android/base/java/org/mozilla/gecko/GeckoApp.java:1591
(Diff revision 2)
> +        }
> +    }
> +
> +    @Override
> +    public void onDoorHangerHide() {
> +        View overlay = getDoorhangerOverlay();

.. and here.

Comment 8

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8856438 [details]
Bug 1352004 - Fix doorhangers missing background.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/128392/diff/2-3/

Comment 9

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s edb131599f6f -d 5ef0eb3d0b26: rebasing 390213:edb131599f6f "Bug 1352004 - Fix doorhangers missing background. r=sebastian" (tip)
merging mobile/android/base/java/org/mozilla/gecko/customtabs/CustomTabsActivity.java
merging mobile/android/base/java/org/mozilla/gecko/webapps/WebAppActivity.java
warning: conflicts while merging mobile/android/base/java/org/mozilla/gecko/webapps/WebAppActivity.java! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 10

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8856438 [details]
Bug 1352004 - Fix doorhangers missing background.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/128392/diff/3-4/

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3148ecea537e
Fix doorhangers missing background. r=sebastian

Comment 12

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/3148ecea537e

Comment 13

[Dale Harvey (:daleharvey)]

> Currently I'm using  .... to test

Thats a super nice trick, I may copy you. I have just been setting manifest.install.enabled=true in prefs and then adding it to the homescreen for reference.

Comment 14

[Oana Horvath [:ohorvath - out of office]]

Verified as fixed on Nightly 55.0a1 (2017-04-20).
Devices:
-LG G4 (Android 5.1)
-Motorola Nexus 6 (Android 7.0)
-Asus ZenPad 8.0 Z380KL (Android 6.0.1)