Closed Bug 1352004 Opened 4 years ago Closed 4 years ago

Doorhangers missing background

Categories

(Firefox for Android Graveyard :: Web Apps (PWAs), defect, P1)

Product:
Firefox for Android Graveyard
Component:
Web Apps (PWAs)
Type:
defect

Tracking

(firefox55 verified)

Status:
VERIFIED FIXED
Milestone:
Firefox 55
Tracking Flags:
Tracking Status
firefox55 --- verified

People

(Reporter: daleharvey, Assigned: cnevinchen)

References

Details

Attachments

(2 files)

Screenshot_20170330-101615.png
75.04 KB, image/png
Details
Bug 1352004 - Fix doorhangers missing background.
59 bytes, text/x-review-board-request
sebastian
: review+
Details 
Install https://daleharvey.github.io/testapp/, launch and click "Get Geolocation"

The doorhanger works but is missing the dark background which is confusing
Blocks: 1285858
Component: General → Web Apps
Priority: -- → P1
Dale, 
let me know if you are able to take this.
Assignee: nobody → dale
Assignee: dale → nobody
I guess you should implement the PopupWindow callback like this.
Please teach me how to install https://daleharvey.github.io/testapp/ so I can work on this.
I try "add to home screen" but it doesn't shows WebAppActivity.

http://searchfox.org/mozilla-central/rev/eace920a0372051a11d8d275bd9b8f14f3024ecd/mobile/android/base/java/org/mozilla/gecko/BrowserApp.java#1620
Flags: needinfo?(dale)
Currently I'm using 
adb shell am start -n "org.mozilla.fennec_nechen/org.mozilla.gecko.App" -a org.mozilla.gecko.WEBAPP  -e MANIFEST_PATH "https://daleharvey.github.io/testapp/manifest.json" -d "https://daleharvey.github.io/testapp/"
to test
Assignee: nobody → cnevinchen
Comment on attachment 8856438 [details]
Bug 1352004 - Fix doorhangers missing background.

https://reviewboard.mozilla.org/r/128392/#review131970

::: mobile/android/base/java/org/mozilla/gecko/GeckoApp.java:1580
(Diff revision 2)
>          mFormAssistPopup = (FormAssistPopup) findViewById(R.id.form_assist_popup);
>      }
>  
> +    @Override
> +    public void onDoorHangerShow() {
> +        View overlay = getDoorhangerOverlay();

nit: final

::: mobile/android/base/java/org/mozilla/gecko/GeckoApp.java:1591
(Diff revision 2)
> +        }
> +    }
> +
> +    @Override
> +    public void onDoorHangerHide() {
> +        View overlay = getDoorhangerOverlay();

.. and here.
Attachment #8856438 - Flags: review?(s.kaspari) → review+
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s edb131599f6f -d 5ef0eb3d0b26: rebasing 390213:edb131599f6f "Bug 1352004 - Fix doorhangers missing background. r=sebastian" (tip)
merging mobile/android/base/java/org/mozilla/gecko/customtabs/CustomTabsActivity.java
merging mobile/android/base/java/org/mozilla/gecko/webapps/WebAppActivity.java
warning: conflicts while merging mobile/android/base/java/org/mozilla/gecko/webapps/WebAppActivity.java! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
Pushed by nechen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3148ecea537e
Fix doorhangers missing background. r=sebastian
https://hg.mozilla.org/mozilla-central/rev/3148ecea537e
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
> Currently I'm using  .... to test

Thats a super nice trick, I may copy you. I have just been setting manifest.install.enabled=true in prefs and then adding it to the homescreen for reference.
Flags: needinfo?(dale)
Verified as fixed on Nightly 55.0a1 (2017-04-20).
Devices:
-LG G4 (Android 5.1)
-Motorola Nexus 6 (Android 7.0)
-Asus ZenPad 8.0 Z380KL (Android 6.0.1)
Status: RESOLVED → VERIFIED
status-firefox55: fixed → verified
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.