Closed
Bug 1352008
Opened 8 years ago
Closed 8 years ago
ensure the Seek call in FrameAnimator UpdateState succeeds
Categories
(Core :: Graphics: ImageLib, defect)
Core
Graphics: ImageLib
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: tnikkel, Assigned: tnikkel)
References
Details
Attachments
(1 file)
|
1.22 KB,
patch
|
aosmond
:
review+
|
Details | Diff | Splinter Review |
The return value of Seek is of utmost importance. Which is a pretty bad api. If you don't check that the return is success then it will happily and silently seek to the first frame for you and return that when you ask for the frame.
The UpdateState function from bug 1343341 did not take this into account.
|
Assignee | |
Comment 1•8 years ago
|
||
Attachment #8852826 -
Flags: review?(aosmond)
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8852826 [details] [diff] [review]
patch
Review of attachment 8852826 [details] [diff] [review]:
-----------------------------------------------------------------
The good news is that this code will go away when we kill FrameAnimator (possible once BlendAnimationFilter is used).
Attachment #8852826 -
Flags: review?(aosmond) → review+
Pushed by tnikkel@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3de61f5929f7
Check return value of DrawableSurface::Seek because if it failed it will return the first frame when you ask for a frame. r=aosmond
|
||
Comment 4•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•