Closed Bug 1352035 Opened 9 years ago Closed 9 years ago

Intermittent devtools/client/netmonitor/test/browser_net_html-preview.js | Uncaught exception - at chrome://mochitests/content/browser/devtools/client/netmonitor/test/browser_net_html-preview.js:37 - TypeError: document.querySelector(...) is null

Categories

(DevTools :: Netmonitor, defect, P1)

Product:
DevTools
Component:
Netmonitor
Type:
defect

Tracking

(firefox55 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 55
Tracking Flags:
Tracking Status
firefox55 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: locke12456, Mentored)

References

Details

Attachments

(2 files)

Bug 1352035 - Removed test case for preview-panel.
59 bytes, text/x-review-board-request
Honza
: review+
Details
Bug 1352035 - Removed the dependency on the test case preview-panel settings.
59 bytes, text/x-review-board-request
Honza
: review+
Details
@Locke: this seems to be related to bug 1350229 you have been working on. Looks like we can remove the test. Honza
Flags: needinfo?(locke12456)
Priority: -- → P1
@Honza:Ok,I'll fix it. :) Can you assign this issue to me?
Flags: needinfo?(locke12456) → needinfo?(odvarko)
Done! Honza
Assignee: nobody → locke12456
Mentor: odvarko
Status: NEW → ASSIGNED
Flags: needinfo?(odvarko)
Blocks: 1350229
Comment on attachment 8853232 [details] Bug 1352035 - Removed test case for preview-panel. https://reviewboard.mozilla.org/r/125298/#review127902 You need to remove also: * html_content-type-test-page.html * const CONTENT_TYPE_URL = ... (in head.js) Honza
Attachment #8853232 - Flags: review?(odvarko)
Ok, I got it. Thank you,@honza
Comment on attachment 8853370 [details] Bug 1352035 - Removed the dependency on the test case preview-panel settings. https://reviewboard.mozilla.org/r/125488/#review128044 Thanks! Honza
Attachment #8853370 - Flags: review?(odvarko) → review+
Keywords: intermittent-failure → checkin-needed
Autoland can't push this because the first patch doesn't have sufficient review for landing.
Keywords: checkin-needed
Sorry, I have no idea how to operate it. should I reset these commit and push again? many thanks!
Flags: needinfo?(odvarko)
(In reply to Locke Chen from comment #12) > Sorry, I have no idea how to operate it. should I reset these commit and > push again? > many thanks! No need to push again, I just R+ the first patch. Honza
Flags: needinfo?(odvarko)
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/autoland/rev/d5c4cf3eeb84 Removed test case for preview-panel. r=Honza https://hg.mozilla.org/integration/autoland/rev/9cb3f1aee967 Removed the dependency on the test case preview-panel settings. r=Honza
Keywords: checkin-needed
(In reply to Jan Honza Odvarko [:Honza] from comment #14) > (In reply to Locke Chen from comment #12) > > Sorry, I have no idea how to operate it. should I reset these commit and > > push again? > > many thanks! > No need to push again, I just R+ the first patch. > > Honza So that's how it is. I understand. Thank you.
https://hg.mozilla.org/mozilla-central/rev/d5c4cf3eeb84 https://hg.mozilla.org/mozilla-central/rev/9cb3f1aee967
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: