1352057 - Add test for icons in the locationbar

Status: RESOLVED WORKSFORME

(Firefox :: Address Bar, task, P3)

Description

[Marco Bonardo [:mak]]

We don't have a very good test checking that icons for the various locationbar result types are properly returned, there was an incomplete one in Marionette that I removed since it was partial and hard to maintain.
We can do something simpler in xpcshell.

Comment 1

[James Teow [:jteow]]

Do we have tests for this or is this something that still needs to be done? Are these tests sufficient:

https://searchfox.org/mozilla-central/source/browser/components/urlbar/tests/browser/browser_oneOffs_heuristicRestyle.js#197

Comment 2

[Drew Willcoxon :adw]

I'll have to defer to Marco on this because I'm not quite sure what this is about.

Comment 3

[Marco Bonardo [:mak]]

I think the scope here is to have a test covering favicons for the most common result types.

I found https://searchfox.org/mozilla-central/rev/8329a650e3b4f866176ae54016702eb35fb8b0d6/browser/components/urlbar/tests/browser/browser_view_resultDisplay.js#55, various tests checking search results icons, and the one you found.
While that's not 100% coverage, I think for the kind of disruption this may cause (annoyance/visual memory) that is likely sufficient, or at least the cost/benefit ratio is moving towards being more of a cost.