1352099 - [PWA] Web Apps don't always have a title and icon in the task switcher entry

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Web Apps (PWAs), defect, P1)

Description

[Oana Horvath [:ohorvath - out of office]]

Attachment: ft - webapp task.png

Device:  LG G4 (Android 5.1) & Huawei Honor 8 (Android 6.0)
Build: Nightly 55.0a2 (2017-03-30);

Steps to reproduce:
1. Install a web app like: Financial Times (ft.com), or pokedex.org.
2. Open the web app.
3. Open the recent apps tray and check the task's title and icon.

Expected result:
Each web app should have a title & icon from the app's manifest.

Actual result:
Web apps tasks don't always have an icon and title. See screenshots attached.

notes: These two app examples initially had shown the correct icon and title, but while testing, I've found that they stopped working correctly and started showing only a generic "Web App" title and the Nightly icon. Can not determine an exact cause, I've reset Nightly and re-installed the web apps, with the same results.

Comment 1

[Oana Horvath [:ohorvath - out of office]]

Attachment: pokedex- task.png

Comment 2

[Dale Harvey (:daleharvey)]

I have seen this occasionally, will investigate

Comment 3

[Dale Harvey (:daleharvey)]

I am seeing this more often when I am using multiple webapps, if I only have 1 it works fine, but if I am constantly opening new ones, possibly a probably with webappindexer and reusing activities

Comment 4

[Dale Harvey (:daleharvey)]

ok found it, the background activity is being killed and during onCreate for some reason getIntent().getStringExtra is not returning anything

Comment 5

[Dale Harvey (:daleharvey)]

Ah I can see how the saveInstanceState is being used in other activities now

Comment 6

[Dale Harvey (:daleharvey)]

Attachment: Ensure manifest can be read on resume

I based this patch on top of https://bugzilla.mozilla.org/show_bug.cgi?id=1352726, got rid of having both loadManifest + updateFromManifest since that seemed unnecessary.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d716fd77f2c9
Ensure manifest can be read on resume. r=sebastian

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d716fd77f2c9

Comment 9

[Oana Horvath [:ohorvath - out of office]]

Verified as fixed on Nightly 55 (2017-04-05).
Devices:
- Motorola Nexus 6 (Android 7.0)
- LG G4 (Android 5.1)
- LG G4 (Android 6.0)

Note: on Huawei Honor 8 (Android 6.0), Xiaomi Mi Pad 2 (Android 5.1), Huawei MediaPad M2 (Android 5.1.1) the tasks still don't have a title and icon, just the generic "WebApp" name and the Nightly icon. These all have the EMUI system.

Comment 10

[Oana Horvath [:ohorvath - out of office]]

(In reply to Oana Horvath from comment #9)
> Verified as fixed on Nightly 55 (2017-04-05).
> Devices:
> - Motorola Nexus 6 (Android 7.0)
> - LG G4 (Android 5.1)
> - LG G4 (Android 6.0)
> 
> Note: on Huawei Honor 8 (Android 6.0), Xiaomi Mi Pad 2 (Android 5.1), Huawei
> MediaPad M2 (Android 5.1.1) the tasks still don't have a title and icon,
> just the generic "WebApp" name and the Nightly icon. These all have the EMUI
> system.
Forgot to mention here that the web apps behave the same on Chrome on these devices: without custom icon and title. 
I will file a new bug if it's possible to solve this.