1352101 - Twitter links no longer work after Twitter automatically installs its PWA service worker (network connection corrupted)

Status: RESOLVED WORKSFORME

(Firefox for Android Graveyard :: General, defect, P2)

Description

[Mike Kaply [:mkaply]]

If you go to a page that has a twitter link (http://www.otsukare.info/2017/03/30/broken-discussion-on-css - click on provocative tweet) with the Twitter app installed, you instead get an error page:

Corrupted Content Error

The site at xxx has experience a network protocol violation that cannot be repaired.

If you uninstall the Twitter app, it works.

This fails on 52/52, works on nightly

Screenshot here:

https://irccloud.mozilla.com/file/C0DaSlOh/Screenshot_20170329-201923.png

Comment 1

[Richard Newman [:rnewman]]

<mib_q8iglh> I indeed have uninstalled the twitter app. After that, I restored Firefox using Titanium Backup, cleared cache en cookies. I will try with a fresh profiles with Twitter already uninstalled.
<mib_q8iglh> Okay, fresh install AFTER uninstalling the Twitter app, the links are working.
<mib_q8iglh> So removing the app does work
<mib_q8iglh> Restoring a firefox profile which I was using when Twitter was installed, the links don't work anymore. So somethink in the profile is corrupt?



Smells like ActivityChooserModel to me. ACM listens for ACTION_PACKAGE_REMOVED to update its state; restoring from backup would also restore the model registry file.

Comment 2

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

P2 and plus first to let the devs look into this.

Comment 3

[Jan Henning [:JanH]]

Before we go chasing down red herrings, I think mkaply meant the Twitter *Progressive Web* App. I've just hit this problem on Release and I've never even had the Twitter *Android* app installed.

A temporary - and less invasive - is to go to about:serviceworkers and unregister Twitter's service worker.

Comment 4

[Jan Henning [:JanH]]

So thankfully only 52 is affected and copy-pasting the same link into the adress bar is also working, but of course neither workaround is immediately obvious (and if uninstall the service worker it'll immediately install itself again the next time you visit Twitter).

As it's more than a week until our next release, is there something we can do until then?

Comment 5

[Nevin Chen(Not active on Bugzilla)]

Hi Jan, Mike
Sorry I can't reproduce this issue.
My STR:
1. Open Release/Nightly Fennec and go to twitter.com and login
2. In Fennec, Go to menu->Pages->Add to HomeScreen. A mobile launcher icon apears.
3. Close Fennec
4. Click the new added launcher[1]
5. Click a link in the feed. <---- I expected to see an error here, but I can't see any.

Could you please help me to reproduce it?



[1] Release version(52) shows the desktop icon with Twitter icon. But nightly shows only "T". But this is not related to this bug.

Comment 6

[Jan Henning [:JanH]]

The homescreen shortcut is unrelated. My STR are:
1. Open about:serviceworkers and unregister anything by Twitter.
2. Click on the Twitter link here: http://logs.glob.uno/?c=mozilla%23mobile&s=7+Apr+2017&e=7+Apr+2017#c624248
3. It loads normally.
4. Switch to about:serviceworkers and refresh until you can see that the Twitter service worker has been successfully reinstalled (active cache name is showing an UUID)
5. Close the twitter tab and open the link from http://logs.glob.uno/?c=mozilla%23mobile&s=7+Apr+2017&e=7+Apr+2017#c624248 again
6. Page loading fails with the error mentioned above (Corrupted Content Error)

Comment 7

[Mike Kaply [:mkaply]]

The Twitter app situation was clearly a red herring. I honestly wasn't sure what was causing it and that was just a guess.

We still need to know what caused this even though it is fixed in Firefox 53 because if it is a 52 regression, we need to fix it in the ESR.

Are we sure it's fixed in 53?

Comment 8

[Jan Henning [:JanH]]

Definitively fixed in 53 by https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=07b9aab24f30b7172e4b6553773c382200b32488&tochange=0c212b76bca625813bae097ff2b8765b07261895, i.e. most probably bug 1271692.

Comment 9

[Ben Kelly [:bkelly, not reviewing]]

I'm having difficulty reproducing this.  Do we know what exception is being thrown by the fetch event handler?  We could ask twitter to maybe fix that while we wait for FF53 to release.

Comment 10

[Jan Henning [:JanH]]

When faking a mobile UA (so the mobile service worker gets installed) I can reproduce this on Desktop as well. Loading with the console open, I see e.g.
> TypeError: Referrer URL http://logs.glob.uno/?c=mozilla%23mobile&s=7+Apr+2017&e=7+Apr+2017 cannot be cross-origin to the entry settings object (https://mobile.twitter.com).  main.1dc737bd24d2b80a.js:1

Comment 11

[Ben Kelly [:bkelly, not reviewing]]

Thanks.  I'll notify twitter about this.  They are making this mistake:

https://github.com/whatwg/fetch/issues/245#issue-140279457

We have updated to the new spec to avoid this exception in FF54.  AFAIK chrome has not implemented this yet, either.

Comment 12

[Ben Kelly [:bkelly, not reviewing]]

Twitter says they have deployed a fix.  Can you retest?

Comment 13

[Ben Kelly [:bkelly, not reviewing]]

Actually, they had to roll back for another issue.  We can re-test tomorrow.

Comment 14

[Paul Armstrong]

FYI: We finished deploying the fix on April 12th, 16:12 America/Los_Angeles

Comment 15

[Ben Kelly [:bkelly, not reviewing]]

(In reply to Paul Armstrong from comment #14)
> FYI: We finished deploying the fix on April 12th, 16:12 America/Los_Angeles

Thanks for the quick fix!  Verified I can follow the link to twitter on my FF52 fennec device now.

Marking WFM since we didn't actually change anything on our side here.