1352108 - Nightly custom tab display a blank page when device orientation is changed

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Sorina Florean [:sflorean]]

Environment: 
Device: Nexus 6 (Android 7.1.1);
Build: Nightly 55.0a1 (2017-03-30);
Prerequisite: Custom tab enabled in Nightly Settings;

Steps to reproduce:
1. Open a Nightly custom tab;
2. Change device orientation from landscape to portrait a couple of times.

Expected result:
Nightly custom tab display the page with no issues.

Actual result:
Nightly custom tab is displaying a blank page for 1-2 sec after the orientation is changed.

Notes:
Not reproducible on Chrome.

Comment 1

[Rachelle Yang [:ryang][[e-mail]]]

The symptom is related to native gecko design.
suggest to remove this bug from  MVP scope( phase1 delivery)  

Hi Joe, 
Could you please share your ideas about this bug per PM's perspective?

Thank you very much !!

Comment 2

[Julian Chu [:walkingice]]

I am not sure the issue is due to native gecko or java side architecture. I think the first step we should put more time on GeckoApp.java to find the root cause.

Comment 3

[Sorina Florean [:sflorean]]

The blank page is still displayed 1-2 sec after the device is changing orientation on latest Nightly. Tested with HTC 10 (Android 7.0) and Huawei MediaPad M2 (Android 5.1.1).

Comment 4

[Joe Cheng [:jcheng] (please needinfo)]

per team's meeting last week, this needs to be fixed for the custom tab feature release. thanks

Comment 5

[Jan Henning [:JanH]]

Wild guess: The custom tab manifest declaration (https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/AndroidManifest.xml.in#314) doesn't include any config change handling (compare https://dxr.mozilla.org/mozilla-central/rev/8e969cc9aff49f845678cba5b35d9dd8aa340f16/mobile/android/base/AndroidManifest.xml.in#65 and https://dxr.mozilla.org/mozilla-central/rev/8e969cc9aff49f845678cba5b35d9dd8aa340f16/mobile/android/base/WebAppManifestFragment.xml.frag.in), so on rotation the activity is completely destroyed and recreated.

Comment 6

[Jan Henning [:JanH]]

Attachment: Bug 1352108 - Add missing attributes to custom tab activity declaration.

Not handling the appropriate configuration changes means that e.g. each rotation destroys and recreates the CustomTabActivity, which'll introduce a slight delay until we eventually repaint the web content.

As for the soft input mode, if we don't specify adjustResize, then the IME might actually simply overlap our window and obscure the end of content if the user has already scrolled down as far as possible.

Review commit: https://reviewboard.mozilla.org/r/133092/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/133092/

Comment 7

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8861139 [details]
Bug 1352108 - Add missing attributes to custom tab activity declaration.

https://reviewboard.mozilla.org/r/133092/#review135908

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cf585ad6f208
Add missing attributes to custom tab activity declaration. r=sebastian

Comment 9

[Iris Hsiao [:ihsiao]]

https://hg.mozilla.org/mozilla-central/rev/cf585ad6f208

Comment 10

[Sorina Florean [:sflorean]]

Verified as fixed on latest Nightly build 55.0a1 from 2017-05-08;
Devices: Honor 8 (Android 6.0) and Asus ZenPad 8(Android 6.0.1).

Blank page when device is changing orientation isn't displayed on CustomTabActivity.