Creating a tab of a deleted container is permitted

RESOLVED WORKSFORME

Status

()

Toolkit
WebExtensions: General
P2
normal
RESOLVED WORKSFORME
9 months ago
20 days ago

People

(Reporter: jkt, Unassigned)

Tracking

(Blocks: 1 bug)

52 Branch
x86_64
Linux
Points:
---

Firefox Tracking Flags

(firefox57 fix-optional)

Details

(Whiteboard: triaged)

(Reporter)

Description

9 months ago
When I use:

browser.tabs.create({url: confirmUrl, cookieStoreId: `firefox-container-2`})

Where I have deleted container 2, the browser opens the tab in a non container, I personally think this should be an exception as it might make developers easily open up privacy issues where they didn't check the containerId.

In my own use case it actually makes the code a lot more complex as I don't currently have the contextualIdentities api.

The contextualIdentities api coming in 53 will allow me to check for this however I would prefer to reduce code complexity and errors.

I would also push for using the userContextId instead of/also for creating tabs and referencing them.
(Reporter)

Comment 1

9 months ago
I forgot to mention the created tab actually has the correct cookieStoreId rather than default.

This prevents me implementing the fix for this in web extensions in 52.

Updated

8 months ago
Priority: -- → P2
Whiteboard: triaged
(Reporter)

Updated

8 months ago
Blocks: 1191418
Bulk change per https://bugzilla.mozilla.org/show_bug.cgi?id=1401020
status-firefox57: --- → fix-optional

Comment 3

20 days ago
Based on your comment 1, is this still valid?
Flags: needinfo?(jkt)
(Reporter)

Comment 4

20 days ago
Yeah I think this got fixed with the changes in 57. Lets close this.
Status: NEW → RESOLVED
Last Resolved: 20 days ago
Flags: needinfo?(jkt)
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.