1352234 - nsImageRenderer.cpp and nsCSSRenderingGradients.h only compile by accident

Status: RESOLVED FIXED

(Core :: Web Painting, enhancement)

Description

[Markus Stange [:mstange]]

because they get unified together with nsCSSRendering.cpp.

If you add a new file to the same directory (like bug 1299117 does), you get lots of build failures.

Comment 1

[Markus Stange [:mstange]]

Attachment: Bug 1352234 - Make nsImageRenderer.cpp and nsCSSRenderingGradients.h compile independent of build unification.

A few includes and namespace annotations are missing. And
nsImageRenderer.cpp is calling two functions that are static functions in
nsCSSRendering.cpp.

Review commit: https://reviewboard.mozilla.org/r/125218/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/125218/

Comment 2

[Markus Stange [:mstange]]

Comment on attachment 8853144 [details]
Bug 1352234 - Make nsImageRenderer.cpp and nsCSSRenderingGradients.h compile independent of build unification.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/125218/diff/1-2/

Comment 3

[Ryan Hunt [:rhunt] (on leave until early May)]

Comment on attachment 8853144 [details]
Bug 1352234 - Make nsImageRenderer.cpp and nsCSSRenderingGradients.h compile independent of build unification.

https://reviewboard.mozilla.org/r/125218/#review127786

Thank you for doing the work that I should have done. Sorry about that!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/07f4fa4c1f8f
Make nsImageRenderer.cpp and nsCSSRenderingGradients.h compile independent of build unification. r=rhunt

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/07f4fa4c1f8f