Closed
Bug 1352235
Opened 8 years ago
Closed 8 years ago
NodeInfoManager should use a local cache for recently used nodeinfos to avoid slow hashtable lookups
Categories
(Core :: DOM: Core & HTML, enhancement)
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: smaug, Assigned: smaug)
References
Details
Attachments
(1 file, 1 obsolete file)
|
5.65 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
This has also a fix relying on bug 1351303.
|
Assignee | |
Comment 1•8 years ago
|
||
Without the bug 1351303 stuff.
Attachment #8853146 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 2•8 years ago
|
||
Comment on attachment 8853148 [details] [diff] [review]
v2
-m "Bug 1352235, try to avoid slow hashtable lookups when getting a nodeinfo, r=bz"
31 is rather magical prime number. We use currently that in ContentLists and I use the same in NS_Atomize fix.
Can't easily avoid minor code duplication since there are those two ways to get NodeInfo, one using nsIAtom, one using nsAString.
Attachment #8853148 -
Flags: review?(bzbarsky)
|
||
Comment 3•8 years ago
|
||
Comment on attachment 8853148 [details] [diff] [review]
v2
r=me
Attachment #8853148 -
Flags: review?(bzbarsky) → review+
Pushed by opettay@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/71bcf82f64b9
try to avoid slow hashtable lookups when getting a nodeinfo, r=bz
|
|
||
Comment 5•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•