Closed Bug 1352239 Opened 3 years ago Closed 2 years ago

permissions.request() should not prompt for permissions an extension already has

Categories

(WebExtensions :: General, enhancement)

enhancement
Not set

Tracking

(firefox55 wontfix, firefox56 fixed)

RESOLVED FIXED
mozilla56
Tracking Status
firefox55 --- wontfix
firefox56 --- fixed
Blocking Flags:
webextensions ?

People

(Reporter: aswan, Assigned: aswan)

Details

(Whiteboard: [permissions], triaged)

Attachments

(1 file)

No description provided.
QA Whiteboard: triaged
Whiteboard: [permissions], triaged
webextensions: --- → ?
Attachment #8883056 - Flags: review?(kmaglione+bmo)
Comment on attachment 8883056 [details]
Bug 1352239 Don't prompt for optional permissions an extension already has

https://reviewboard.mozilla.org/r/154018/#review160454

::: toolkit/components/extensions/test/mochitest/test_chrome_ext_permissions.html:211
(Diff revision 2)
> +  let win = window.open(url);
> +  await extension.awaitMessage("page-ready");
> +
> +  let winutils = SpecialPowers.getDOMWindowUtils(win);

:(
Attachment #8883056 - Flags: review?(kmaglione+bmo) → review+
Pushed by aswan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d6a2aaf96c60
Don't prompt for optional permissions an extension already has r=kmag
https://hg.mozilla.org/mozilla-central/rev/d6a2aaf96c60
Status: NEW → RESOLVED
Closed: 2 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Too late for 55. Mark 55 won't fix.
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.