Note: There are a few cases of duplicates in user autocompletion which are being worked on.

permissions.request() should not prompt for permissions an extension already has

RESOLVED FIXED in Firefox 56

Status

()

Toolkit
WebExtensions: General
RESOLVED FIXED
4 months ago
8 days ago

People

(Reporter: aswan, Assigned: aswan)

Tracking

Trunk
mozilla56
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox55 affected, firefox56 fixed)

Details

(Whiteboard: [permissions], triaged)

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

Comment hidden (empty)

Updated

3 months ago
QA Whiteboard: triaged

Updated

3 months ago
Whiteboard: [permissions], triaged
(Assignee)

Updated

3 months ago
webextensions: --- → ?
Comment hidden (mozreview-request)
(Assignee)

Updated

19 days ago
Attachment #8883056 - Flags: review?(kmaglione+bmo)
Comment hidden (mozreview-request)

Comment 3

15 days ago
mozreview-review
Comment on attachment 8883056 [details]
Bug 1352239 Don't prompt for optional permissions an extension already has

https://reviewboard.mozilla.org/r/154018/#review160454

::: toolkit/components/extensions/test/mochitest/test_chrome_ext_permissions.html:211
(Diff revision 2)
> +  let win = window.open(url);
> +  await extension.awaitMessage("page-ready");
> +
> +  let winutils = SpecialPowers.getDOMWindowUtils(win);

:(
Attachment #8883056 - Flags: review?(kmaglione+bmo) → review+
Comment hidden (mozreview-request)

Comment 5

9 days ago
Pushed by aswan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d6a2aaf96c60
Don't prompt for optional permissions an extension already has r=kmag

Comment 6

8 days ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/d6a2aaf96c60
Status: NEW → RESOLVED
Last Resolved: 8 days ago
status-firefox56: --- → fixed
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.