Closed
Bug 1352239
Opened 7 years ago
Closed 7 years ago
permissions.request() should not prompt for permissions an extension already has
Categories
(WebExtensions :: General, enhancement)
WebExtensions
General
Tracking
(firefox55 wontfix, firefox56 fixed)
RESOLVED
FIXED
mozilla56
webextensions | ? |
People
(Reporter: aswan, Assigned: aswan)
Details
(Whiteboard: [permissions], triaged)
Attachments
(1 file)
No description provided.
Updated•7 years ago
|
QA Whiteboard: triaged
Updated•7 years ago
|
Whiteboard: [permissions], triaged
Assignee | ||
Updated•7 years ago
|
webextensions: --- → ?
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Attachment #8883056 -
Flags: review?(kmaglione+bmo)
Comment hidden (mozreview-request) |
Comment 3•7 years ago
|
||
mozreview-review |
Comment on attachment 8883056 [details] Bug 1352239 Don't prompt for optional permissions an extension already has https://reviewboard.mozilla.org/r/154018/#review160454 ::: toolkit/components/extensions/test/mochitest/test_chrome_ext_permissions.html:211 (Diff revision 2) > + let win = window.open(url); > + await extension.awaitMessage("page-ready"); > + > + let winutils = SpecialPowers.getDOMWindowUtils(win); :(
Attachment #8883056 -
Flags: review?(kmaglione+bmo) → review+
Comment hidden (mozreview-request) |
Pushed by aswan@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d6a2aaf96c60 Don't prompt for optional permissions an extension already has r=kmag
Comment 6•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/d6a2aaf96c60
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Comment 7•7 years ago
|
||
Too late for 55. Mark 55 won't fix.
Updated•6 years ago
|
Product: Toolkit → WebExtensions
You need to log in
before you can comment on or make changes to this bug.
Description
•