Closed
Bug 1352308
Opened 8 years ago
Closed 8 years ago
stylo: ServoRestyleManager::AttributeChanged has a somewhat fishy assert
Categories
(Core :: CSS Parsing and Computation, enhancement, P3)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
DUPLICATE
of bug 1355343
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | affected |
People
(Reporter: bzbarsky, Unassigned)
References
Details
It's doing:
#ifdef DEBUG
ServoElementSnapshot* snapshot = Servo_Element_GetSnapshot(aElement);
MOZ_ASSERT_IF(snapshot, snapshot->HasAttrs());
#endif
but Servo_Element_GetSnapshot has side-effects (e.g. see bug 1352306) so doing it on a debug-only codepath is pretty questionable.
We should have a side-effect-free thing that does the check we want here.
|
||
Updated•8 years ago
|
Priority: -- → P3
|
||
Comment 1•8 years ago
|
||
This was fixed by the snapshot refactor I did in bug 1355343.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•