Closed Bug 1352339 Opened 8 years ago Closed 8 years ago

[Build bustage] Add a missing include and missing 'using namespace' to Windows widget code

Categories

(Core :: Printing: Output, enhancement)

Product:
Core
Component:
Printing: Output
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla55
Tracking Flags:
Tracking Status
firefox55 --- fixed

People

(Reporter: fatseng, Assigned: fatseng)

References

Details

Attachments

(2 files, 1 obsolete file)

Bug 1352339 - Add missing WinCompositorWidget.h include to nsWindowsGfx.cpp
59 bytes, text/x-review-board-request
jwatt
: review+
Details
Bug 1352339 - Add missing 'using namespace mozilla' to nsWindowDbg.cpp
59 bytes, text/x-review-board-request
jwatt
: review+
Details
No description provided.
Blocks: 1345710
Comment on attachment 8853340 [details] Bug 1352339 - Add missing WinCompositorWidget.h include to nsWindowsGfx.cpp Hit nsWindowGfx.cpp build break. Miss to include "WinCompositorWidget.h" 1:34.38 c:/mozilla-source/gecko-0215/widget/windows/nsWindowGfx.cpp(252): error C2027: use of undefined type 'mozilla::widget::CompositorWidgetDelegate' 1:34.38 c:\mozilla-source\gecko-0215\obj-i686-pc-mingw32\dist\include\mozilla/widget/CompositorWidget.h(46): note: see declaration of 'mozilla::widget::CompositorWidgetDelegate' 1:34.38 c:/mozilla-source/gecko-0215/widget/windows/nsWindowGfx.cpp(252): error C2227: left of '->GetTransparentDC' must point to class/struct/union/generic type 1:34.38 c:/mozilla-source/gecko-0215/widget/windows/nsWindowGfx.cpp(326): error C2027: use of undefined type 'mozilla::widget::WinCompositorWidget' 1:34.38 c:\mozilla-source\gecko-0215\obj-i686-pc-mingw32\dist\include\mozilla/widget/CompositorWidget.h(36): note: see declaration of 'mozilla::widget::WinCompositorWidget' 1:34.38 c:/mozilla-source/gecko-0215/widget/windows/nsWindowGfx.cpp(326): error C2039: 'EnsureTransparentSurface': is not a member of 'RefPtr<mozilla::widget::WinCompositorWidget>' 1:34.38 c:\mozilla-source\gecko-0215\widget\windows\nsWindow.h(647): note: see declaration of 'RefPtr<mozilla::widget::WinCompositorWidget>' 1:34.38 c:/mozilla-source/gecko-0215/widget/windows/nsWindowGfx.cpp(391): error C2027: use of undefined type 'mozilla::widget::WinCompositorWidget' 1:34.38 c:\mozilla-source\gecko-0215\obj-i686-pc-mingw32\dist\include\mozilla/widget/CompositorWidget.h(36): note: see declaration of 'mozilla::widget::WinCompositorWidget' 1:34.38 c:/mozilla-source/gecko-0215/widget/windows/nsWindowGfx.cpp(391): error C2039: 'RedrawTransparentWindow': is not a member of 'RefPtr<mozilla::widget::WinCompositorWidget>' 1:34.38 c:\mozilla-source\gecko-0215\widget\windows\nsWindow.h(647): note: see declaration of 'RefPtr<mozilla::widget::WinCompositorWidget>'
Attachment #8853340 - Flags: review?(jwatt)
Comment on attachment 8853341 [details] Bug 1352339 - Add missing 'using namespace mozilla' to nsWindowDbg.cpp Add 'using namespace mozilla' to fix build break. Build failed log: 0:44.26 c:/mozilla-source/gecko-0215/widget/windows/nsWindowDbg.cpp(43): error C2653: 'LogLevel': is not a class or namespace name 0:44.27 c:/mozilla-source/gecko-0215/widget/windows/nsWindowDbg.cpp(43): error C2065: 'Info': undeclared identifier 0:44.29 c:/mozilla-source/gecko-0215/widget/windows/nsWindowDbg.cpp(54): error C2653: 'LogLevel': is not a class or namespace name 0:44.30 c:/mozilla-source/gecko-0215/widget/windows/nsWindowDbg.cpp(54): error C2065: 'Error': undeclared identifier
Attachment #8853341 - Flags: review?(jwatt)
Attachment #8853342 - Attachment is obsolete: true
Summary: [Build bustage] /mozilla-central/widget/windows/ failed and warning → [Build bustage] Add a missing include and missing 'using namespace' to Windows widget code
Comment on attachment 8853340 [details] Bug 1352339 - Add missing WinCompositorWidget.h include to nsWindowsGfx.cpp https://reviewboard.mozilla.org/r/125440/#review127984 ::: commit-message-8e155:1 (Diff revision 1) > +Bug 1352339 - Add a missing include to nsWindowsGfx.cpp Make this "Add missing WinCompositorWidget.h include to nsWindowsGfx.cpp" And add a second line saying "We need the definition of CompositorWidgetDelegate in order to use mCompositorWidgetDelegate."
Attachment #8853340 - Flags: review?(jwatt) → review+
Comment on attachment 8853341 [details] Bug 1352339 - Add missing 'using namespace mozilla' to nsWindowDbg.cpp https://reviewboard.mozilla.org/r/125442/#review127986 ::: commit-message-58b1c:1 (Diff revision 1) > +Bug 1352339 - Add a missing 'using namespace mozilla' to nsWindowDbg.cpp Change "Add a" to just "Add" (since we only need to ever do that once, and "Add a" implies there may be more 'using namespace mozilla'). :) Also add a second line saying "Needed because LogLevel is in the 'mozilla' namespace, but this file uses it without qualification."
Attachment #8853341 - Flags: review?(jwatt) → review+
Comment on attachment 8853340 [details] Bug 1352339 - Add missing WinCompositorWidget.h include to nsWindowsGfx.cpp Carry over r+ flag.
Attachment #8853340 - Flags: review+
Comment on attachment 8853341 [details] Bug 1352339 - Add missing 'using namespace mozilla' to nsWindowDbg.cpp Carry over r+ flag.
Attachment #8853341 - Flags: review+
Assignee: nobody → fatseng
Status: NEW → ASSIGNED
Comment on attachment 8853341 [details] Bug 1352339 - Add missing 'using namespace mozilla' to nsWindowDbg.cpp https://reviewboard.mozilla.org/r/125442/#review128018 ::: commit-message-58b1c:2 (Diff revision 3) > +Bug 1352339 - Add missing 'using namespace mozilla' to nsWindowDbg.cpp r=jwatt > +Needed because LogLevel is in the 'mozilla' namespace, but this file uses it without qualification. Blank line between the comment summary line and the rest of the expanded comment, please.
Attachment #8853341 - Flags: review+
Comment on attachment 8853340 [details] Bug 1352339 - Add missing WinCompositorWidget.h include to nsWindowsGfx.cpp https://reviewboard.mozilla.org/r/125440/#review128016 ::: commit-message-8e155:2 (Diff revision 3) > +Bug 1352339 - Add missing WinCompositorWidget.h include to nsWindowsGfx.cpp r=jwatt > +We need the definition of CompositorWidgetDelegate in order to use mCompositorWidgetDelegate. The convention is to put a blank line between the first summary line and the expanded comments below it.
Attachment #8853340 - Flags: review+
Comment on attachment 8853340 [details] Bug 1352339 - Add missing WinCompositorWidget.h include to nsWindowsGfx.cpp https://reviewboard.mozilla.org/r/125440/#review128142
Comment on attachment 8853341 [details] Bug 1352339 - Add missing 'using namespace mozilla' to nsWindowDbg.cpp https://reviewboard.mozilla.org/r/125442/#review128144
Keywords: checkin-needed
Pushed by cbook@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0b7e1a20ab6c Add missing WinCompositorWidget.h include to nsWindowsGfx.cpp r=jwatt https://hg.mozilla.org/integration/autoland/rev/1606323068fa Add missing 'using namespace mozilla' to nsWindowDbg.cpp r=jwatt
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/0b7e1a20ab6c https://hg.mozilla.org/mozilla-central/rev/1606323068fa
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: