Use active versions if 0 featured versions

RESOLVED FIXED

Status

Socorro
Webapp
RESOLVED FIXED
8 months ago
8 months ago

People

(Reporter: peterbe, Assigned: peterbe)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

8 months ago
Some products, like SeaMonkey, doesn't have featured versions. It does have active versions though. This requirement breaks the home page because of https://github.com/mozilla/socorro/blob/master/webapp-django/crashstats/home/views.py#L27 and Top Crashers because of this potential IndexError https://github.com/mozilla/socorro/blob/master/webapp-django/crashstats/topcrashers/views.py#L229

In both of these cases we could just rely on all *active* versions instead then those pages would continue to work for products that can't have featured versions because they can't be included in ship-it.
(Assignee)

Updated

8 months ago
Blocks: 973033
(Assignee)

Updated

8 months ago
Blocks: 1349763
(Assignee)

Updated

8 months ago
Blocks: 1349766
(Assignee)

Comment 1

8 months ago
Created attachment 8853408 [details] [review]
Link to Github pull-request: https://github.com/mozilla/socorro/pull/3713

Comment 2

8 months ago
Commit pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/956b21cacec8e0adcec0a9592fa170057620d30f
fixes bug 1352385 - Use active versions if 0 featured versions (#3713)

* fixes bug 1352385 - Use active versions if 0 featured versions

* all nits addressed

Updated

8 months ago
Status: NEW → RESOLVED
Last Resolved: 8 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.