44 bytes, text/x-github-pull-request
|Details | Review | Splinter Review|
Some products, like SeaMonkey, doesn't have featured versions. It does have active versions though. This requirement breaks the home page because of https://github.com/mozilla/socorro/blob/master/webapp-django/crashstats/home/views.py#L27 and Top Crashers because of this potential IndexError https://github.com/mozilla/socorro/blob/master/webapp-django/crashstats/topcrashers/views.py#L229 In both of these cases we could just rely on all *active* versions instead then those pages would continue to work for products that can't have featured versions because they can't be included in ship-it.
Created attachment 8853408 [details] [review] Link to Github pull-request: https://github.com/mozilla/socorro/pull/3713
Commit pushed to master at https://github.com/mozilla/socorro https://github.com/mozilla/socorro/commit/956b21cacec8e0adcec0a9592fa170057620d30f fixes bug 1352385 - Use active versions if 0 featured versions (#3713) * fixes bug 1352385 - Use active versions if 0 featured versions * all nits addressed