Invalid "url" format in Pulse schema

RESOLVED FIXED

Status

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: davehunt, Assigned: davehunt)

Tracking

Details

Attachments

(1 attachment)

Whilst creating Pulse payloads and using the schema for validation I discovered that the "url" format is invalid. According to the specification [1] the following formats are defined:

* date-time
* email
* hostname
* ipv4
* ipv6
* uri
* uriref

Currently the schema defines "url" as the format for jobInfo.properties.links.url [2]. I suspect this should be "uri".

[1] http://json-schema.org/latest/json-schema-validation.html#rfc.section.7.3
[2] https://github.com/mozilla/treeherder/blob/835c90b6eec0e52383a4316beae5da42d0a38b52/schemas/pulse-job.yml#L299
Assignee: nobody → dave.hunt
Attachment #8853412 - Flags: review?(cdawson)
Comment on attachment 8853412 [details] [review]
[treeherder] davehunt:bug1352403 > mozilla:master

Thanks for catching and fixing this!
Attachment #8853412 - Flags: review?(cdawson) → review+
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.