Closed
Bug 1352403
Opened 8 years ago
Closed 8 years ago
Invalid "url" format in Pulse schema
Categories
(Tree Management :: Treeherder, enhancement)
Tree Management
Treeherder
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: davehunt, Assigned: davehunt)
Details
Attachments
(1 file)
Whilst creating Pulse payloads and using the schema for validation I discovered that the "url" format is invalid. According to the specification [1] the following formats are defined:
* date-time
* email
* hostname
* ipv4
* ipv6
* uri
* uriref
Currently the schema defines "url" as the format for jobInfo.properties.links.url [2]. I suspect this should be "uri".
[1] http://json-schema.org/latest/json-schema-validation.html#rfc.section.7.3
[2] https://github.com/mozilla/treeherder/blob/835c90b6eec0e52383a4316beae5da42d0a38b52/schemas/pulse-job.yml#L299
|
||
Comment 1•8 years ago
|
||
|
|
||
Updated•8 years ago
|
Assignee: nobody → dave.hunt
|
|
||
Updated•8 years ago
|
Attachment #8853412 -
Flags: review?(cdawson)
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8853412 [details] [review]
[treeherder] davehunt:bug1352403 > mozilla:master
Thanks for catching and fixing this!
Attachment #8853412 -
Flags: review?(cdawson) → review+
|
||
Comment 3•8 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder
https://github.com/mozilla/treeherder/commit/ea90972662e93597d649463c43ba746022482538
Bug 1352403 - Replace invalid "url" format with "uri" (#2307)
|
|
||
Updated•8 years ago
|
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•