1352433 - First run tour in browser and some settings reset after opening a web app

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Web Apps (PWAs), defect, P1)

Description

[Sebastian Kaspari (:sebastian; :pocmo)]

STR:
* Install a web app (Twitter)
* (Kill all browser / web app instances)
* Start the web app
* Press the home button
* Start the browser

Expected result:
*  The browser should open and restore the last session

Actual result:
* The first run tour shows up (and the session restores in the background)

Comment 1

[Jan Henning [:JanH]]

Haven't explicitly followed your STR, but I've come across this as well. I've noticed that it's more than just the first run tour, though. Privacy -> Clear private data on exit is reset to default (i.e. nothing) as well and I think the same happened to my home panel order.

Comment 2

[Jan Henning [:JanH]]

Attachment: Bug 1352433 - Part 0 - Change variable name casing for constants.

The shared preferences keys used for storing/retrieving the activity list data are constants, so it is a bit disconcerting to see them named like normal member variables.

Review commit: https://reviewboard.mozilla.org/r/125820/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/125820/

Comment 3

[Jan Henning [:JanH]]

Attachment: Bug 1352433 - Part 1 - Don't clear all preferences when all you need to remove is a few keys.

Review commit: https://reviewboard.mozilla.org/r/125822/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/125822/

Comment 4

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8853786 [details]
Bug 1352433 - Part 0 - Change variable name casing for constants.

https://reviewboard.mozilla.org/r/125820/#review128452

Comment 5

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8853787 [details]
Bug 1352433 - Part 1 - Don't clear all preferences when all you need to remove is a few keys.

https://reviewboard.mozilla.org/r/125822/#review128454

Thanks Jan!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a7d2ac78d9f2
Part 0 - Change variable name casing for constants. r=sebastian
https://hg.mozilla.org/integration/autoland/rev/88c7d9a8e6ec
Part 1 - Don't clear all preferences when all you need to remove is a few keys. r=sebastian

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a7d2ac78d9f2
https://hg.mozilla.org/mozilla-central/rev/88c7d9a8e6ec

Comment 8

[Oana Horvath [:ohorvath - out of office]]

Verified as fixed on Nightly 55.0a1 (2017-04-12).
Devices:
- LG G4 (Android 5.1)
- Motorola Nexus 6 (Android 7.0)
- Huawei MediaPad M2 (Android 5.1.1)