1352568 - Telemetry via Leanplum

Status: RESOLVED FIXED

(Firefox for iOS :: Telemetry, defect, P1)

Comment 1

[:sdaswani]

Susheel to discuss with Product, Engineering and Marketing what events we are going to drop and at what granularity.

Comment 2

[:sdaswani]

These are the events that Product / Marketing wants:

Close Private Tabs
Close Private Tabs when leaving Private Browsing
FocusInstalledState - to know if user has Focus installed or not
SavePassword
OpenLoginManager (Settings)
SaveBookmark
OpenBookmark
LoadBookmark
OpenMailToLink - When the user taps a mail link
HasAlternativeMailClient - keep flag to know if users has alternative mail app installed
Or: OpenLink with a type attribute. Then we are also ready for tel: or sms: links.
OpenTab - When a user opens a new tab
Opens the app (first run, second run, last opened)
Users who have not opened the app in x days 
Interact with search url area
Stay on a page for x period of time
Visiting a website x times 
Download videos or any other media

Log an LeanPlum event every time one of these thing happen.

Comment 4

[:sdaswani]

Status:

Blockers:
1) We are still waiting for the Open Source SDK from LP.
2) Jean is going to figure out her thoughts around the following events:

Stay on a page for x period of time
Visiting a website x times 

https://mozilla.slack.com/archives/C4NTWRSNN/p1491847229123484?thread_ts=1491587306.607686&cid=C4NTWRSNN

Comment 5

[Bryan Munar (:bkmunar)]

Attachment: PR - a little gnarly and includes some previous work from this original branch

Comment 6

[:sdaswani]

Merged in https://github.com/mozilla-mobile/firefox-ios/pull/2606/commits/cf540eb129150875d9b980a471eff8972ee6b51a#diff-20aee44903cdc15e455e14f5809446d9R19 .

Comment 7

[:sdaswani]

https://docs.google.com/spreadsheets/d/1XLwjK7eZgDD7ncbQ2Jm37aEMRiylLekOze4u9yEXSeM/edit#gid=1499104175 is the source of truth for events required.

Comment 8

[:sdaswani]

Attachment: Pull Request

This PR differs from the previous version by the following:
1) Removed the custom focus promo (and all changes related to it)
2) Removed the telemetry we were recording during private browsing
3) Removed some changes not related to Leanplum
4) Removed some silly whitespace changes
5) Addressed James' comments, except for two nits.

Now it's all very clearly just about 1) integrating the LP SDK and 2) dropping some events via LP.

Comment 9

[:sdaswani]

Committed in https://github.com/mozilla-mobile/firefox-ios/pull/2711/