13526 - unable to set or read percent through DOM

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, defect, P3)

Description

[Jan Carpenter]

Overview Description:
In tables, for example, I can't read or set cellPadding to a percentage value
through DOM.  The value I receive when I try to read a percentage value is the
same as if I were reading a pixel value.

Steps to Reproduce:
- Will attach example code

Actual Results:
(from the example code) 10

Expected Results:
(from the example code) 10%

Build Date & Platform Bug Found:
Win98 1999090311

Additional Builds and Platforms Tested On:
WinNT, MacPPC, Linux


Additional Information:

Comment 1

[Jan Carpenter]

Attachment: Attaching testcase

Comment 2

[Jan Carpenter]

previous email concerning this bug:

vidur:

Seems like a bug in nsHTMLTableElement's StringToAttribute method. The current
implementation has:

 if ((aAttribute == nsHTMLAtoms::cellspacing) ||
      (aAttribute == nsHTMLAtoms::cellpadding)) {
    if (nsGenericHTMLElement::ParseValue(aValue, 0, aResult, eHTMLUnit_Pixel)) {
      return NS_CONTENT_ATTR_HAS_VALUE;
    }
  }

Seems like we should be calling ParseValueOrPerecent() of ParseValue(). Cc:ing
Peter to make sure I'm right - I've been wrong about
this stuff before.

--V


peterl:

Yes, that should be ParseValueOrPercent. Chris, you also need to ensure that you
handle percent values in AttributeToString and
MapAttributesInto (as well as in the actual cell padding/spacing code).

P

Comment 3

[karnaze (gone)]

The attachment now works. Percentage values actually rendering properly is
another bug and applies to cellpadding, cellspacing, etc.

Comment 4

[Jan Carpenter]

verified

Comment 5

[Jan Carpenter]

verified